Closed Bug 1767109 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33884 - [layout] Switch radio/checkbox to have an intrinsic inline/block size.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33884 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33884
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Switch radio/checkbox to have an intrinsic inline/block size.

... as opposed to setting an explicit width/height when we have an
effective appearance, and the width/height is auto.

This is effectively what the code in layout_theme_default was doing,
but this is in a less broken way.

This has the primary side effect of allowing radio/checkbox to respect
stretching (in flex & grid).

Most of the image differences come at non-integer zooms. E.g.
Previously we'd round down(?) for things like:

13px * 1.5 = 19px
now:
13px * 1.5 = 19.5px

Bug: 768999
Change-Id: I222f07ada71ea56a3656af03b459d7a5007e924d
Reviewed-on: https://chromium-review.googlesource.com/3614268
WPT-Export-Revision: deb6f77640e88f55f0130ba617f5c602c076e789

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d42379126593
[wpt PR 33884] - [layout] Switch radio/checkbox to have an intrinsic inline/block size., a=testonly

https://hg.mozilla.org/mozilla-central/rev/d42379126593

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.