1767123 - Change the return type of nsLayoutUtils::GetTransformToAncestorScale to MatrixScalesDouble

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Botond Ballo [:botond]]

Defined here

Comment 1

[Razvan Cojocaru]

Changing that return type will lead to a conversion problem in nsLayoutUtils::GetTransformToAncestorScaleCrossProcessForFrameMetrics():

ParentLayerToScreenScale2D transformToAncestorScale(nsLayoutUtils::GetTransformToAncestorScale(aFrame));

specifically, ParentLayerToScreenScale2D uses float, and MatrixScalesDouble, as the name implies, uses double.

Do you want an explicit conversion from MatrixScalesDouble to ParentLayerToScreenScale2D, or do you want the return type of GetTransformToAncestorScaleCrossProcessForFrameMetrics() changed to something like ParentLayerToScreenScale2DDouble as well (will require a new using/typedef)?

Comment 2

[Razvan Cojocaru]

Actually, I'll just submit the simplest version of the patch and you can request changes there.

Comment 3

[Razvan Cojocaru]

Attachment: Bug 1767123 - Change the return type of nsLayoutUtils::GetTransformToAncestorScale to MatrixScalesDouble. r?botond

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2654ffd335de
Change the return type of nsLayoutUtils::GetTransformToAncestorScale to MatrixScalesDouble. r=botond

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2654ffd335de