1767175 - tabbar text has wrongly positioned shadows with theme

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect)

Description

[lilydjwg]

Attachment: tabs-text-shadow.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

• install a theme, e.g. https://addons.mozilla.org/firefox/addon/beach-dog-jen/
• open a couple of tabs, presumably ones with long titles
• if not already seen, try to switch tabs and hover on them

Actual results:

There are wrongly positioned text shadows appearing on some of the tabs. (see screenshot).

Expected results:

The text shadows should always match the text.

Comment 1

[lilydjwg]

Oops, I forgot mozregression result:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=01d5f09a02bfe727760cb8498fd866dbdaaff9d4&tochange=5ccaf8100f7912e55bb98cc1951d57df9c4dd511

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:gw, since you are the author of the regressor, bug 1766017, could you take a look?
For more information, please visit auto_nag documentation.

Comment 4

[Glenn Watson [:gw]]

Attachment: Bug 1767175 - Fix calculation for when we can merge batches between render tasks.

Now that the surface allocation is based off the clipped coverage
of child primitives, we need to determine whether we can merge
batches based off the original unclipped surface rect.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b95cf6aaa6e9
Fix calculation for when we can merge batches between render tasks. r=gfx-reviewers,nical

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b95cf6aaa6e9

Comment 9

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Glenn Watson [:gw] - I am requesting the request for the uplift to Firefox 101.

Comment 10

[Glenn Watson [:gw]]

Comment on attachment 9274605 [details]
Bug 1767175 - Fix calculation for when we can merge batches between render tasks.

Beta/Release Uplift Approval Request

• User impact if declined: Visual glitches in titlebars with certain themes. Glitches in content are also possible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Per bug report
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch, has been in nightly for some time. Fixes a definite bug.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Hani Yacoub, Desktop QA]

Managed to reproduce the issue on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 11.6 on Firefox 101.0b3.
The issue isn't reproducible anymore on Firefox 102.0a1 (2022-05-05).

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9274605 [details]
Bug 1767175 - Fix calculation for when we can merge batches between render tasks.

Approved for 101.0b4.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/60c73c5ce426

Comment 14

[Hani Yacoub, Desktop QA]

Verified as fixed on Windows 10 x64, Ubuntu 20.04 x64 and on macOS 11.6 on Firefox 101.0b4.