When falling back to adwaita-dark, also try adwaita+prefers-dark-theme
Categories
(Core :: Widget: Gtk, enhancement)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
On Arch Linux, at least, Adwaita-dark is not a theme, but Adwaita with prefers-dark-theme works.
|
Assignee | |
Comment 1•2 years ago
|
||
I was poking at some Arch Linux stuff, and we detect the dark theme
preference properly, but setting the theme name to Adwaita-dark is not
enough there because Adwaita-dark is not a theme name in there.
Try Adwaita + gtk-application-prefers-dark-theme (which should work in
all modern GTK versions), and fall back to Adwaita-dark only if that
doesn't work.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/919fdaa6e06b When falling back to Adwaita / adwaita-dark, try to also set gtk-application-prefers-dark-theme. r=stransky
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 4•2 years ago
|
||
Comment on attachment 9274581 [details]
Bug 1767199 - When falling back to Adwaita / adwaita-dark, try to also set gtk-application-prefers-dark-theme. r=stransky
Beta/Release Uplift Approval Request
- User impact if declined: Trivial improvement to theming on Linux.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce: If they want, they can use KDE on Arch Linux, select dark appearance, and see how we would keep a light theme, incorrectly, but QA usually doesn't test on various distros and I'm running in such setup so :)
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial tweak to fallback code to try one more thing before giving up.
- String changes made/needed: none
- Is Android affected?: No
|
||
Comment 5•2 years ago
|
||
Comment on attachment 9274581 [details]
Bug 1767199 - When falling back to Adwaita / adwaita-dark, try to also set gtk-application-prefers-dark-theme. r=stransky
Approved for 101.0b2.
|
|
||
Comment 6•2 years ago
|
||
| bugherder uplift | ||
Description
•