1767227 - When nsMsgDatabase is forced to close, it complains about remaining listeners but doesn't remove them

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

In nsMsgDatabase::ForceClosed, there's an assertion that m_ChangeListeners is empty. But if it isn't empty (not entirely sure why this happens), it doesn't get emptied, then the destructor crashes with the message:

Hit MOZ_CRASH(mozilla::LinkedList<nsSHistory>::~LinkedList() [T = nsSHistory] has a buggy user: it should have removed all this list's elements before the list's destruction) at /builds/worker/workspace/obj-build/dist/include/mozilla/LinkedList.h:466

This can currently be seen by running the tests in mail/components/extensions/test/browser with a debug build, and is causing the failures on CI since bug 1176694 landed. I don't think that bug is to blame, it just creates the conditions for failure.

Comment 1

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: Bug 1767227 - Clean up listeners when a message database is forced to close. r=john.bieling

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b1fecdb961a2
Clean up listeners when a message database is forced to close. r=john.bieling

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9274628 [details]
Bug 1767227 - Clean up listeners when a message database is forced to close. r=john.bieling

[Triage Comment]
Approved for 101.0beta per wsmwk via Matrix

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 101.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/728e0f5ef4e0