1767295 - Use a different delay for navigation timers on slow platforms (debug/asan/...)

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P1)

Description

[Julian Descottes [:jdescottes]]

See investigation at Bug 1766708 comment #2, on some platforms the unload timer for the shared waitForNavigationCompleted timer is too low to detect an actual expected navigation.

We should increase the delay used for those timers on slow platforms.

Default timer is set at https://searchfox.org/mozilla-central/rev/a730b83206183bf097820c5780eef0d5e4103b9d/remote/shared/Navigate.jsm#119

We can read debug & asan flags from AppConstants.jsm https://searchfox.org/mozilla-central/rev/a730b83206183bf097820c5780eef0d5e4103b9d/toolkit/modules/AppConstants.jsm#243-255

Suggested by :whimboo on Bug 1766708: "Maybe when doing that we might consider a separate Constants.jsm module for Remote Agent?"

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Maybe we should not just add longer times for ASAN or debug builds but similarly to web-platform tests work with a multiplier. That way we can apply the same behavior to other timeouts as well as long as we are flexible and there is no strict constrain with a specification.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1767295 - [remote] Extend unload timeout for navigation on slow platforms

Comment 3

[Marco Mucci [:MarcoM]]

Hi Julian. Adding this to M4. Add the point value when you are ready.

Comment 4

[Julian Descottes [:jdescottes]]

Alternatively we can disable the perma on ccov

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2f68a727ca4
[remote] Extend unload timeout for navigation on slow platforms r=webdriver-reviewers,whimboo

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b2f68a727ca4