1767385 - [wpt-sync] Sync PR 33905 - [Rollback] Make sure ontrack fires when re-added.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33905 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33905
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

[Rollback] Make sure ontrack fires when re-added.

Follow-up to WebRTC CL:
https://webrtc-review.googlesource.com/c/src/+/260330

Does the Chromium layer equivalent of the WebRTC CL now that the
FiredDirection is restored. In order for rollback to be able to cause
ontrack to fire, DidModifyTransceivers() is updated to be able to fire
ontrack also in the event of "rollback".

RollbackEvents.https.html:

• First two tests: "ontrack" firing due to rollback to remove and then
  re-add passes due to WebRTC CL that restores FiredDirection.
• Last two tests: "ontrack" firing due to the rollback of a track
  removal passes due to the "is_remote_description_or_rollback" logic
  added in this CL.

Bug: chromium:1320669
Change-Id: I04d96393f25e08f76046447db02b04aec87f140e
Reviewed-on: https://chromium-review.googlesource.com/3613313
WPT-Export-Revision: 5a2dc3ed20e9359563e13550588400c19bec6fec

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=00bb79fffb0dab18c6cada67819b54bf180334ea

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL : 8

Chrome

TIMEOUT: 2
NOTRUN : 7

Safari

TIMEOUT: 2
NOTRUN : 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/RollbackEvents.https.html [wpt.fyi]
  • [audio] Track with stream: removal due to disassociation in rollback and then add it back again: FAIL (Chrome: TIMEOUT, Safari: TIMEOUT)
  • [audio] Track without stream: removal due to disassociation in rollback and then add it back: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [audio] Track with stream: removal due to direction changing and then add back using rollback: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [audio] Track without stream: removal due to direction changing and then add back using rollback: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [video] Track with stream: removal due to disassociation in rollback and then add it back again: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [video] Track without stream: removal due to disassociation in rollback and then add it back: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [video] Track with stream: removal due to direction changing and then add back using rollback: FAIL (Chrome: NOTRUN, Safari: NOTRUN)
  • [video] Track without stream: removal due to direction changing and then add back using rollback: FAIL (Chrome: NOTRUN, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af6ee54716ef
[wpt PR 33905] - [Rollback] Make sure ontrack fires when re-added., a=testonly
https://hg.mozilla.org/integration/autoland/rev/aca19f0a3304
[wpt PR 33905] - Update wpt metadata, a=testonly

Comment 4

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/af6ee54716ef
https://hg.mozilla.org/mozilla-central/rev/aca19f0a3304