1767473 - Remaining implementation of recently closed tabs list in Firefox View

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Sarah Clements [:sclements]]

Additional functionality and styling not in bug 1761784

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1767473 - Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster

• add event listener and update list when a tab is closed
• add additional styling, favicon element and keyboard navigation support
• add tests

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c914173639f
Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures(Assertion failures)

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: !foundScriptSrc || StringBeginsWith(aboutSpec, "about:preferences"_ns) || StringBeginsWith(aboutSpec, "about:downloads"_ns) || StringBeginsWith(aboutSpec, "about:newtab"_ns) || StringBeginsWith(aboutSpec, "about:logins"_ns) || StringBeginsWith(aboutSpec, "about:compat"_ns) || StringBeginsWith(aboutSpec, "about:welcome"_ns) || StringBeginsWith(aboutSpec, "about:profiling"_ns) || StringBeginsWith(aboutSpec, "about

Comment 4

[Sarah Clements [:sclements]]

Hi Christian, I don't think that particular failure has anything to do with my patch. I added browser_recently_closed_tabs.js mochitests in my patch and the try push passed, so I don't really understand why it failed on autoland.

Comment 5

[Cristian Tuns]

Hello, I got this TV jobs that helped me find the regression bug: https://treeherder.mozilla.org/logviewer?job_id=378989135&repo=autoland
Anyway, I triggered some backfills, If it turns out that your patch did not caused that issue, we will reland.

Comment 6

[Sarah Clements [:sclements]]

(In reply to Cristian Tuns from comment #5)

Hello, I got this TV jobs that helped me find the regression bug: https://treeherder.mozilla.org/logviewer?job_id=378989135&repo=autoland
Anyway, I triggered some backfills, If it turns out that your patch did not caused that issue, we will reland.

Gijs pointed out that I probably need to change the code here, so looks like my patch was the culprit :(

Comment 7

[Iulian Moraru]

Backfills also point to the recent changes made on this bug.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6894cf5a5c7
Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster

Comment 9

[Cristian Tuns]

Backed out for causing mochitest failures on browser_firefoxview_tab.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_firefoxview_tab.js | Closing about:about added to the closed tab count - Got +0, expected 1

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61a84f80e879
Add additional functionality to closed tabs in Firefox View r=Gijs,sfoster

Comment 11

[Cristian Tuns]

Sorry for backout, look the issue was caused by another bug. reland link

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/61a84f80e879