1767506 - Many fields going to additionalProperties in org-mozilla-focus/metrics ping

Status: RESOLVED FIXED

(Data Platform and Tools :: General, task, P1)

Description

[Jeff Klukas [:klukas] (UTC-4)]

In our weekly health check, we are seeing many missing fields in the focus metrics ping like:

`metrics`.`timing_distribution`.`paint.build_displaylist_time`.`sum`
`metrics`.`timing_distribution`.`fog.ipc.flush_durations`.`values`.[...]

each with over 1 million occurrences in the past week.

These look like valid metric name from gecko-dev. See them showing up for Fenix, for example: https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/paint_build_displaylist_time

I'm guessing that Focus Android is using gecko-dev and sending these metrics, but isn't set up in probe-scraper to list gecko-dev as a dependency.

?ni :janerik and :chutten for thoughts on whether this theory makes sense and thoughts on whether we should add the dependency.

Comment 1

[Chris H-C :chutten]

Excellently caught. Yes, it didn't occur to me that Focus Android is now (and has been for years, how could I forget) powered by geckoview. Whoops! It needs a gecko library dependency.

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: data-review-request-focus.md

Filing this on behalf of Amedyne Moya as the Focus owner.
Amedyne, please ack this so we're sure you're the right person to be responsible there.

I'll file the PR for the necessary changes.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/probe-scraper/pull/426

Comment 5

[Jan-Erik Rediger [:janerik]]

Comment on attachment 9276400 [details]
data-review-request-focus.md

I just learned that the data review is not necessary, as its covered by the initial reviews already.

Comment 6

[Jan-Erik Rediger [:janerik]]

badboy merged PR #426: "Bug 1767506 - Add gecko dependency for Focus/Klar" in 4554beb.