1767516 - Subtitles on Netflix are duplicated on all platforms

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Ania]

Attachment: dHGScc3.png

Affected Platforms: All

STR:

1. Turn on subtitles in any Netflix video
2. Launch PiP
   Expected result: subtitles track is displayed in PiP.
   Actual result: subtitles track is displayed and duplicatedin PiP.

Comment 1

[Ania]

Attachment: macos.png

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1767516 - Update Netflix site adapter to use nested span for subtitles. r=#pip-reviewers!

Comment 3

[Ania]

Quote from Niklas for visibility on what happened here:

Netflix changed how they display captions on their videos. The text is now inside a second span that wasn't there when we created the site adapter. The adapter grabs all spans within a caption element and because there are two spans now, we return the text twice.

Comment 4

[Niklas Baumgardner [:niklas]]

Comment on attachment 9274869 [details]
Bug 1767516 - Update Netflix site adapter to use nested span for subtitles. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Netflix changed how they display captions on their site and users are currently seeing the caption lines doubled. With the big release of PiP in 100, many users are testing out subtitles in PiP and noticing the bug with doubled caption lines. We would like to get this resolved in release as soon as possible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ensure media.videocontrols.picture-in-picture.display-text-tracks.enabled is set to true

2. Navigate to Netflix and find any video with captions.
3. Make sure the captions are on in the Netflix player and open a PiP window.
4. Confirm that each caption line from the Netflix player only shows once in the PiP window.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only affects users who watching Netflix videos in Picture-in-Picture with subtitles enabled. This change will fix the doubling of caption lines that currently occur. We would like to include this in the next dot release.
• String changes made/needed: No
• Is Android affected?: No

Comment 5

[Niklas Baumgardner [:niklas]]

Comment on attachment 9274869 [details]
Bug 1767516 - Update Netflix site adapter to use nested span for subtitles. r=#pip-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Netflix changed how they display captions on their site and users are currently seeing the caption lines doubled. With the big release of PiP in 100, many users are testing out subtitles in PiP and noticing the bug with doubled caption lines. We would like to get this resolved in release as soon as possible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Ensure media.videocontrols.picture-in-picture.display-text-tracks.enabled is set to true
  2.Navigate to Netflix and find any video with captions.

3. Make sure the captions are on in the Netflix player and open a PiP window.
4. Confirm that each caption line from the Netflix player only shows once in the PiP window.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only affects users who watching Netflix videos in Picture-in-Picture with subtitles enabled. This change will fix the doubling of caption lines that currently occur. We would like to include this in the next dot release.
• String changes made/needed: No
• Is Android affected?: No

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/506998126f71
Update Netflix site adapter to use nested span for subtitles. r=pip-reviewers,mhowell

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/506998126f71

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9274869 [details]
Bug 1767516 - Update Netflix site adapter to use nested span for subtitles. r=#pip-reviewers!

Approved for 101.0b3.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b5913ac48ad7

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9274869 [details]
Bug 1767516 - Update Netflix site adapter to use nested span for subtitles. r=#pip-reviewers!

Approved for 100.0.1

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/a6ee65853a00

Comment 13

[Daniel Bodea [:danibodea]]

I managed to verify this in Nightly so far, but could not continue. The Widevine simply won't install anymore. Bug 1767953.
Been searching for a way to manually install Widevine manually by using a hack but it did not work.

Comment 14

[Daniel Bodea [:danibodea]]

I have managed to verify this fix using an updated version of the hack above.
It was verified on Nightly v102.0a1, Beta v101.0b3 (20220504181604) and Dot Release v100.0.1 (20220505112524), on Windows 10, Ubuntu 20.04.4 LTS.
Also verified Nightly v102.0a1 on Mac OS 11. For various reasons, the remaining builds could not be verified with this hack.