176754 - Context menu and tooltips triggers assertion

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Nicholas Allen]

Opening a context menu triggers one assertion to repeatedly fire (5 or 6 times 
per context menu).  Using CVS build 1 AM 10/25 Win2k.

Steps:

1) Start browser
2) Right click in content

###!!! ASSERTION: frame state bit was set but frame has no view: 'value != 0', f
ile d:/mozilla/mozilla/layout/html/base/src/nsFrame.cpp, line 2266

nsFrame::GetView(const nsFrame * const 0x036ec224, nsIPresContext * 0x015fbac8, 
nsIView * * 0x0012ee2c) line 2266 + 32 bytes
nsFrame::GetParentWithView(const nsFrame * const 0x037550c4, nsIPresContext * 
0x015fbac8, nsIFrame * * 0x0012ee60) line 2332
nsMenuPopupFrame::GetRootViewForPopup(nsIPresContext * 0x015fbac8, nsIFrame * 
0x037550c4, nsIView * * 0x0012ef00) line 524
nsMenuPopupFrame::AdjustClientXYForNestedDocuments(nsIDOMXULDocument * 
0x01516df8, nsIPresShell * 0x0164d100, int 0x00000189, int 0x00000097, int * 
0x0012f0b4, int * 0x0012f0ac) line 629 + 26 bytes
nsMenuPopupFrame::SyncViewWithFrame(nsIPresContext * 0x015fbac8, const nsString 
& {...}, const nsString & {...}, nsIFrame * 0x03177bdc, int 0x00000189, int 
0x00000097) line 994
nsPopupSetFrame::RepositionPopup(nsPopupFrameList * 0x0361e598, 
nsBoxLayoutState & {...}) line 341
nsPopupSetFrame::DoLayout(nsPopupSetFrame * const 0x02f87b24, nsBoxLayoutState 
& {...}) line 234
nsBox::Layout(nsBox * const 0x02f87b24, nsBoxLayoutState & {...}) line 1066
nsSprocketLayout::Layout(nsSprocketLayout * const 0x015ff8a8, nsIBox * 
0x02f87a14, nsBoxLayoutState & {...}) line 528
nsContainerBox::DoLayout(nsContainerBox * const 0x02f87a14, nsBoxLayoutState & 
{...}) line 607 + 34 bytes
nsBoxFrame::DoLayout(nsBoxFrame * const 0x02f87a14, nsBoxLayoutState & {...}) 
line 1100
nsBox::Layout(nsBox * const 0x02f87a14, nsBoxLayoutState & {...}) line 1066
nsStackLayout::Layout(nsStackLayout * const 0x02facfb0, nsIBox * 0x02f87860, 
nsBoxLayoutState & {...}) line 331
nsContainerBox::DoLayout(nsContainerBox * const 0x02f87860, nsBoxLayoutState & 
{...}) line 607 + 34 bytes
nsBoxFrame::DoLayout(nsBoxFrame * const 0x02f87860, nsBoxLayoutState & {...}) 
line 1100
nsBox::Layout(nsBox * const 0x02f87860, nsBoxLayoutState & {...}) line 1066
nsBoxFrame::Reflow(nsBoxFrame * const 0x02f87828, nsIPresContext * 0x015fbac8, 
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 
0x00000000) line 900
nsRootBoxFrame::Reflow(nsRootBoxFrame * const 0x02f87828, nsIPresContext * 
0x015fbac8, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 242
nsContainerFrame::ReflowChild(nsIFrame * 0x02f87828, nsIPresContext * 
0x015fbac8, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, int 
0x00000000, int 0x00000000, unsigned int 0x00000000, unsigned int & 0x00000000) 
line 926 + 31 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x02f87720, nsIPresContext * 
0x015fbac8, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, 
unsigned int & 0x00000000) line 579
IncrementalReflow::Dispatch(nsIPresContext * 0x015fbac8, nsHTMLReflowMetrics & 
{...}, const nsSize & {...}, nsIRenderingContext & {...}) line 894
PresShell::ProcessReflowCommands(int 0x00000001) line 6512
ReflowEvent::HandleEvent() line 6357
HandlePLEvent(ReflowEvent * 0x037b2bb8) line 6371
PL_HandleEvent(PLEvent * 0x037b2bb8) line 644 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x00f91ef0) line 574 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x00840114, unsigned int 0x0000c09e, unsigned 
int 0x00000000, long 0x00f91ef0) line 1335 + 9 bytes
USER32! 77e3a290()
USER32! 77e145b1()
USER32! 77e15b1d()
nsAppShellService::Run(nsAppShellService * const 0x00fe9260) line 472
main1(int 0x00000001, char * * 0x00276d90, nsISupports * 0x00276df8) line 1522 
+ 32 bytes
main(int 0x00000001, char * * 0x00276d90) line 1883 + 37 bytes
mainCRTStartup() line 338 + 17 bytes
KERNEL32! 77e9ca90()

Walking down the stack and looking at the code and checkins, the fix for bug 
172276 looks suspicious.

Comment 1

[tm]

I see same behaivor with CVS 20021102.  Running XP, built with VC7 if that matters. 

Most of the time I get 3 assertions, context menu displays, then I get three
more assertions when the menu disappears - whether I pick anything on it or
simply click off it.  Sometimes I just get six assertions in a row, with the
'shadow' of the menu appearing about halfway through - no menu appears in this case.

Interestingly I get the same assertion when I hover over a link with a 'tooltip'
style display (e.g. to reproduce hover mousepointer over the bug 172276 link in
comment #1.) three assertions, 'tooltip' displays, three more assertions.

Comment 2

[Nicholas Allen]

Bugzilla horked that update, trying again.  Sorry about the spam.

Comment 3

[tm]

This is fixed for me by bzbarskys' checkin for bug 180329.

Comment 4

[Nicholas Allen]

This is fixed.