1767574 - Profile Manager - Optical Regression for Buttons and Headlines

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Bug in Profile Manager.png

I'm using Windows 11 64-Bit and the issue is only for adding new profiles. The other dialogs in Profile Manager are okay.

In Profile Manager, when adding a new profile, there is an optical issue with the buttons (only the text ist visible, but not the button borders and background). Additionally the headlines in these panes do not follow, what Firefox 99 / 100 shows visually.

Maybe the buttons (and the headlines) are a HTML / CSS regression, due to the fact, that we have to follow a Firefox/Toolkit change.

Maybe this could be fixed before 102 release.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

The issue with the buttons is existing in 91 ESR (91.9.0), too.

Comment 2

[Thomas D. (:thomas8)]

Thanks Alex for pointing out this little nit in one of Thunderbird's most remote corners!
Hey-ho!!!! Haven't seen that screen forever, almost to the extent of forgetting that it exists.
I understand that the buttons are still working, right?

(In reply to Alex Ihrig [:Thunderbird_Mail_DE] from comment #0)

Maybe the buttons (and the headlines) are a HTML / CSS regression, due to the fact, that we have to follow a Firefox/Toolkit change.

Most likely. Richard would know!

Maybe this could be fixed before 102 release.

Not urgent or important tbh, but perhaps simple enough.

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

I understand that the buttons are still working, right?

Yes, they are still working.

perhaps simple enough

This was my hope for this litte, but existing issue.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Bug 1767574 - Add :host to the themeableDialog.css variables to apply on wizard too. r=aleca

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/616a670026cc
Add :host to the themeableDialog.css variables to apply on wizard too. r=aleca

Comment 6

[Magnus Melin [:mkmelin]]

Looks like this is causing
TEST-UNEXPECTED-FAIL | comm/mail/test/static/browser_parsable_css.js | Got error message for chrome://messenger/skin/shared/themeableDialog.css: :host selector in ‘:host:-moz-lwtheme’ is not featureless and will never match. Maybe you intended to use :host()? -

Comment 7

[Richard Marti (:Paenglab)]

Ah, :host doesn't support the -moz-lwtheme pseudo class.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1767574 - Remove the not supported -moz-lwtheme pseudo class on :host. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/50ce62ae8e16
Remove the not supported -moz-lwtheme pseudo class on :host. r=mkmelin

Comment 10

[Alex Ihrig [:Thunderbird_Mail_DE]]

Fixed and again verified in Daily 2022-05-07 (after removing not supported -moz-lwtheme).