1767679 - Intermittent devtools/client/inspector/rules/test/browser_rules_colorpicker-and-image-tooltip_01.js | single tracking bug

The assumption here is that the inspector initialization is slower when there is a "swatch" widget to render. Here it's a color swatch, in another related intermittent it was a filter swatch. The various screenshots show the inspector in various shapes which seem to indicate it is still initializing.

Julian Descottes [:jdescottes]

Assignee

Comment 12

•

2 years ago

Attached file Bug 1767679 - [devtools] Wait for element to be ready in browser_rules_colorpicker-and-image-tooltip_01.js — Details

No conclusive results on try. Waiting for the property container to be ready should at least help invsestigate if we get more failures

Phabricator Automation

Updated

•

2 years ago

Assignee: nobody → jdescottes

Status: NEW → ASSIGNED

Julian Descottes [:jdescottes]

Assignee

Comment 13

•

2 years ago

Interestingly, skipping the test makes another test fail again: https://treeherder.mozilla.org/jobs?repo=try&revision=cf0f1d2bdff482b6959406be6ae5658a2743e8e8

But it's not the next immediate test (which would be browser_rules_colorpicker-and-image-tooltip_02.js), it's the one after that: browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js

All 3 tests use very similar properties so it's surprising that only 2 of them lead to intermittent failures:

browser_rules_colorpicker-and-image-tooltip_01.js

    body {
      background: url("chrome://branding/content/icon64.png"), linear-gradient(white, #F06 400px);
    }

browser_rules_colorpicker-and-image-tooltip_02.js:

    body {
      background: red url("chrome://branding/content/icon64.png")
        no-repeat center center;
    }

browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js:

    body {
      color: red;
      background-color: #ededed;
      background-image: url(chrome://branding/content/icon64.png);
      border: 2em solid rgba(120, 120, 120, .5);
    }

Flags: needinfo?(jdescottes)

Julian Descottes [:jdescottes]

Assignee

Comment 14

•

2 years ago

Since this other test seemed to have a higher failure rate on try, I applied the same fix as the one pushed here to it, and it seems to validate that the fix works: https://treeherder.mozilla.org/jobs?repo=try&revision=c15d18ec7c430cc69e662729a16585b813edb6e4

So in theory if we get other getRuleViewProperty(...) is undefined errors er could apply the same fix. In the long run I see 2 options:

make getRuleViewProperty async and wait until the element is available
use the other test to find a proper event we could wait for

Comment hidden (Intermittent Failures Robot)

Pulsebot

Comment 16

•

2 years ago

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d83579bec018
[devtools] Wait for element to be ready in browser_rules_colorpicker-and-image-tooltip_01.js r=Honza

Julian Descottes [:jdescottes]

Assignee

Updated

•

2 years ago

Blocks: 1778985