Closed Bug 176768 Opened 22 years ago Closed 22 years ago

XML-RPC: onStopRequest signature wrong

Categories

(Core :: XML, defect)

Product:
Core
Component:
XML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: hjtoi-bugzilla, Assigned: samuel)

Details

Attachments

(1 file)

fix
1.27 KB, patch
hjtoi-bugzilla
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review 
The signature for onStopRequest has changed, but this implementation has not
been updated. Check the number and type of arguments.
Attached patch fix — — Splinter Review 

    
    

    
  
I noticed you changed the onError call as well, but there are several onError
calls in this file. I am not sure what signature is correct, but they should be
all the same at least.

    
    

    
  
I didn't change onError.  It still has the same signature.

    
  
QA Contact: petersen → rakeshmishra

    
  

        Attachment #104730 -
        Flags: superreview?(darin)

        Attachment #104730 -
        Flags: review?(heikki)

    
  
Keywords: patch

    
    

    
  
Comment on attachment 104730 [details] [diff] [review]
fix

sr=darin

        Attachment #104730 -
        Flags: superreview?(darin) → superreview+

        Attachment #104730 -
        Flags: review?(heikki) → review+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: