Closed
Bug 176768
Opened 23 years ago
Closed 23 years ago
XML-RPC: onStopRequest signature wrong
Categories
(Core :: XML, defect)
Core
XML
Tracking
()
RESOLVED
FIXED
People
(Reporter: hjtoi-bugzilla, Assigned: samuel)
Details
Attachments
(1 file)
|
1.27 KB,
patch
|
hjtoi-bugzilla
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
The signature for onStopRequest has changed, but this implementation has not
been updated. Check the number and type of arguments.
|
Assignee | |
Comment 1•23 years ago
|
||
|
Reporter | |
Comment 2•23 years ago
|
||
I noticed you changed the onError call as well, but there are several onError
calls in this file. I am not sure what signature is correct, but they should be
all the same at least.
|
|
Assignee | |
Comment 3•23 years ago
|
||
I didn't change onError. It still has the same signature.
|
||
Updated•23 years ago
|
QA Contact: petersen → rakeshmishra
|
|
Assignee | |
Updated•23 years ago
|
Attachment #104730 -
Flags: superreview?(darin)
Attachment #104730 -
Flags: review?(heikki)
|
||
Comment 4•23 years ago
|
||
Comment on attachment 104730 [details] [diff] [review]
fix
sr=darin
Attachment #104730 -
Flags: superreview?(darin) → superreview+
|
|
Reporter | |
Updated•23 years ago
|
Attachment #104730 -
Flags: review?(heikki) → review+
|
|
Assignee | |
Comment 5•23 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•