Closed Bug 1767686 Opened 3 years ago Closed 4 months ago

Intermittent devtools/client/inspector/rules/test/browser_rules_gridline-names-autocomplete.js | single tracking bug

Categories

(DevTools :: Inspector: Rules, defect, P3)

defect

Tracking

(firefox145 fixed)

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: jmaher, Assigned: nchevobbe)

References

Details

(Keywords: intermittent-failure, intermittent-testcase)

Attachments

(2 files, 1 obsolete file)

No description provided.

Filter on devtools-intermittent-singletrackingbug-triage

Severity: -- → S4
Attachment #9383247 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 9 months ago6 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

Started spiking on macos end of August (~aug 25).
Nicolas, did we land anything related to autocompletion around this day?

Flags: needinfo?(nchevobbe)

(In reply to Julian Descottes [:jdescottes] from comment #139)

Started spiking on macos end of August (~aug 25).
Nicolas, did we land anything related to autocompletion around this day?

nothing specific to autocomplete really, Bug 1984021 and Bug 1983410 modified code that could be involved in this test, maybe impacting some timing and causing a race condition?

Flags: needinfo?(nchevobbe)

Thanks for checking might be something outside of devtools then. Both landed a few days before the spike, so probably not directly related.

Assignee: nobody → nchevobbe
Status: REOPENED → ASSIGNED

The test could end up in a bad state when a property name was being edited and
the TAB key was pressed.

In such case, the property name is "commited", the autocomplete popup is closed,
the editor for the property value is created, and the autocomplete popup is
shown again, without selecting any item.

The test wasn't handling this well, only waiting for grid-line-names-updated and
not for the popup to be closed and reopened again.

This patchs adds a new item in the test data to indicate when we're in this case,
and builds an array of promises to wait for before pressing the key so we can
handle listening for the popup to be closed and reopened again.

Use bit flags instead of having individual array items for each state we want
to check)

Pushed by nchevobbe@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b9543ad5faed https://hg.mozilla.org/integration/autoland/rev/2b25e2d1fb68 [devtools] Fix browser_rules_gridline-names-autocomplete.js intermittent. r=devtools-reviewers,jdescottes. https://github.com/mozilla-firefox/firefox/commit/6941e209dbcf https://hg.mozilla.org/integration/autoland/rev/37e7be5fbb14 [devtools] Refactor browser_rules_gridline-names-autocomplete.js test data shape. r=devtools-reviewers,jdescottes.
Status: ASSIGNED → RESOLVED
Closed: 6 months ago4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
See Also: → 1985681
See Also: → 1990541
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: