Closed Bug 1767810 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33931 - Revert "Update accessibility subtree when an event listener is removed"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33931 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33931
Details from upstream follow.

Joanmarie Diggs <jdiggs@igalia.com> wrote:

Revert "Update accessibility subtree when an event listener is removed"

This reverts commit 753632c02ff8ea047d707122ba1706d9bc4c7bc0.

Reason for revert: Test flakiness on Windows. See crbug.com/1321954.

Original change's description:

Update accessibility subtree when an event listener is removed

If an object was included in the accessibility tree solely due to an
event listener which was just removed, that object will be marked as
dirty and subsequently as ignored. When BlinkAXTreeSource::GetChildren
is then called due to serialization of updates and events, the parent of
that now-ignored object will have a child it should not and a DCHECK
will fail.

This commit solves that problem by calling ChildrenChangedOnAncestorOf
if the event listener was removed on an existing AXObject. Doing so
causes the accessibility tree to be updated prior to serialization of
updates and events. It includes an additional change and test from
crrev.com/c/3608668.

AX-Relnotes: N/A

Bug: 1319933
Change-Id: Ibb4b78d480d940c8274db75b3739cda0e253933e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614009
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Joanmarie Diggs \<jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#997215}

Bug: 1319933
Change-Id: I0796d33398c9d1f16ef7c2895ce728291850a6f4

Reviewed-on: https://chromium-review.googlesource.com/3625719
WPT-Export-Revision: 923c0a556fd0aa8bf2ba13e28669eb76bf5e52f0

PR 33931 applied with additional changes from upstream: 9f49a05f17e71cd3a9fdb214fda03fe5937e2f77
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/464bb8ff5231 [wpt PR 33931] - Revert "Update accessibility subtree when an event listener is removed", a=testonly

https://hg.mozilla.org/mozilla-central/rev/464bb8ff5231

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.