1767815 - [HiDPI] Graphical artifact on the bottom right corner of tooltips

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Itiel]

Attachment: Screenshot

See screenshot, this is very similar to bug 1704040.
This is visible also on light theme.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1765423

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1765423, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[nayinain]

Attachment: Screenshots.png

I can reproduce this issue.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Err, comment 3 looks much worse than it should be (comment 0). What are your DPI settings and OS version? Also do you see the same offset on context menus? Thanks.

Comment 5

[nayinain]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Err, comment 3 looks much worse than it should be (comment 0). What are your DPI settings and OS version? Also do you see the same offset on context menus? Thanks.

DPI: 100%
OS: Windows 10.0.19043
No，Occurs only in the tooltips of the tabs or bookmarks.

Comment 6

[nayinain]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Err, comment 3 looks much worse than it should be (comment 0). What are your DPI settings and OS version? Also do you see the same offset on context menus? Thanks.

I found the cause of the issue. I don't know when I set browser.proton.places-tooltip.enabled to true.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1767815 - Remove shadow from windows tooltips. r=dao,Gijs

Looks fairly ugly in HiDPI, and release doesn't have shadows either, so it's
probably fine.

This allows me to clean-up -moz-window-shadow, as with bug 1768278 this is the
last use in the tree.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9275573 [details]
Bug 1767815 - Remove shadow from windows tooltips. r=dao,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: Bug 1765423
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removes one CSS declaration added in bug 1765423 which causes an ugly artifact in HiDPI. We might want to keep it as-is tho, since the artifact is also on context menus.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca383a27eb51
Remove shadow from windows tooltips. r=dao

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ca383a27eb51

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9275573 [details]
Bug 1767815 - Remove shadow from windows tooltips. r=dao,Gijs

Approved for 101.0b5.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f360ee2f0dd

Comment 13

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build (2022-05-04) on Windows 10 x64.
Verified as fixed on Firefox 101.0b5 (20220510144626) and Firefox 102.0a1 (20220510213954) on Windows 10 x64.