1767820 - Stop allowing addTrack to set the addTrackMagic bit in RTCRtpTransceiver

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task, P3)

Description

[Byron Campen [:bwc]]

RTCRtpTransceivers created by addTrack are allowed to automatically associate with m-sections in a remote offer, as opposed to transceivers created with addTransceiver; this is referred to in our codebase as "addTrackMagic". Years ago, the spec authors intended to allow a subsequent call to addTrack to set this bit on a transceiver created by addTransceiver, but this never actually happened, and was never implemented in Chrome.

At this point, we probably need to remove this behavior, since it is unlikely it will ever make it into the spec.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1767820: Only set addTrack magic for transceivers _created_ by addTrack. r?jib

Depends on D168433

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=488298132e7b78b8d24f737fae1b41a7d8eb5015
https://treeherder.mozilla.org/jobs?repo=try&revision=da49dd8b7f9c00f3411d3f102bdcc5b12f794ff1
https://treeherder.mozilla.org/jobs?repo=try&revision=8ae4137c220dc733b01dd7410d8ac64eb5cdad20

Comment 3

[Byron Campen [:bwc]]

Seeing some intermittents, double-checking for significant rate increases.

Comment 4

[Byron Campen [:bwc]]

Try looks fine.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d6de9c29d1e
Only set addTrack magic for transceivers _created_ by addTrack. r=mjf

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8d6de9c29d1e