Closed Bug 1767871 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33936 - Fix all .gitignore related WPTLint errors

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox102 fixed)

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33936 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33936
Details from upstream follow.

Bruce Dawson <brucedawson@chromium.org> wrote:

Fix all .gitignore related WPTLint errors

After rolling WPTLint with this fix:

 https://github.com/web-platform-tests/wpt/pull/33697

the WPTLint checks started reporting on long-standing .gitignore issues.
These were:

.gitignore found outside the root (GITIGNORE)
cors/resources/.gitignore
css/.gitignore
css/css-writing-modes/tools/generators/.gitignore
resources/.gitignore
webaudio/.gitignore

matches an ignore filter in .gitignore (IGNORED PATH)
content-security-policy/support/manifest.json
payment-handler/manifest.json
resource-timing/resources/manifest.json
testharness_runner.html

The .gitignore files in child directories were handled with entries in
lint.ignore. The manifest.json IGNORED_PATH errors were because of a
MANIFEST.json entry in the root-level .gitignore file - on Windows that
also matches manifest.json. Adding a leading slash fixed that.

Finally, testharness_runner.html has been checked in since at least 2016
but has a .gitignore entry specifically for it. I am assuming that the
.gitignore entry is in error so I deleted it. That .gitignore entry was
last modified in 2019 (crrev.com/c/1527876) which presumably only
happened because the .gitignore linting was broken at that time.

With this change the following command now runs clean:

 git cl presubmit --files=third_party/blink/web_tests/external/wpt/*

Bug: 1318089
Change-Id: Idf8b45b92b27513a668d1a672ca72600d53b5b74
Reviewed-on: https://chromium-review.googlesource.com/3625631
WPT-Export-Revision: ad63a8bcaf7fa098a29b0d0f2a171f9c83bec6d2

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d26da73825c3
[wpt PR 33936] - Fix all .gitignore related WPTLint errors, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d26da73825c3

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.