Closed Bug 1768003 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33946 - Always create an anonymous contents wrapper inside a fieldset.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33946 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33946
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

Always create an anonymous contents wrapper inside a fieldset.

This way we'll have less to worry about in the layout algorithm.
Padding handling was incorrect, and it caused an infinite loop, because
the algorithm expected the anonymous child to take care of trailing
padding, and therefore didn't pass it to FinishFragmentation(). We
therefore failed to treat the trailing padding as monolithic.

We need to treat padding as monolithic, or we might never get past it if
it's taller than the fragmentainer (and push it ahead of us into the
next fragmentainer infinitely). The fragmentation code would believe
that we managed to fit some of it in one fragmentainer, but we'd in fact
try again from the start of the padding-block-end in the next
fragmentainer (because it should be monolithic, that's why!) - forever.

Just making sure that there's always an anonymous contents wrapper
simplifies things and fixes bugs, including a minor correctness bug;
see the new test empty-scrollable.html

Some unit tests had to be updated. These expectations were mostly last
touched by CL:2960239 , which eliminated the need for anonymous content
wrappers if the fieldset only had a legend child. Now we'll always
create them.

Bug: 1322426
Change-Id: I215ecd6387e388d0a6801476b6269cb8fb84cba3
Reviewed-on: https://chromium-review.googlesource.com/3629580
WPT-Export-Revision: 22b1d22d444dd4a91f119524eb1be089e6eaf261

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS : 2

Chrome

FAIL : 1
TIMEOUT: 1

Safari

PASS : 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9db71e04316
[wpt PR 33946] - Always create an anonymous contents wrapper inside a fieldset., a=testonly

https://hg.mozilla.org/mozilla-central/rev/e9db71e04316

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.