Closed Bug 1768035 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 33948 - Fix all .gitignore related WPTLint errors

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33948 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33948
Details from upstream follow.

Bruce Dawson <brucedawson@chromium.org> wrote:

Fix all .gitignore related WPTLint errors

After rolling WPTLint with this fix:

 https://github.com/web-platform-tests/wpt/pull/33697

the WPTLint checks started reporting on long-standing .gitignore issues.
These were:

.gitignore found outside the root (GITIGNORE)
cors/resources/.gitignore
css/.gitignore
css/css-writing-modes/tools/generators/.gitignore
resources/.gitignore
webaudio/.gitignore

matches an ignore filter in .gitignore (IGNORED PATH)
content-security-policy/support/manifest.json
payment-handler/manifest.json
resource-timing/resources/manifest.json
testharness_runner.html

The .gitignore files in child directories were handled with entries in
lint.ignore. The manifest.json IGNORED_PATH errors were because of a
MANIFEST.json entry in the root-level .gitignore file - on Windows that
also matches manifest.json. Adding a leading slash fixed that.

Finally, testharness_runner.html has been checked in since at least 2016
but has a .gitignore entry specifically for it. I am assuming that the
.gitignore entry is correct so I deleted the file.

With this change the following command now runs clean:

 git cl presubmit --force --files=third_party/blink/web_tests/external/wpt/*

Bug: 1318089
Change-Id: Icbe268176b41a102499da43398aae49d3f3ab7f2
Reviewed-on: https://chromium-review.googlesource.com/3630559
WPT-Export-Revision: 36f0f4b1a23540244b6b866a437a901d5bfd9723

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.