1768067 - Remove the Assertion at nsHttpConnectionMgr.cpp:3380

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Dan Robertson (:dlrobertson)]

With a Debug + ASan build on a Mac I hit this assertion when I run ./mach run =

Comment 1

[Dan Robertson (:dlrobertson)]

Attachment: moz_log.log

MOZ_LOG from ./mach run -MOZ_LOG=nsHttp:5 ...

Comment 2

[Dan Robertson (:dlrobertson)]

Attachment: stderr.log

The stderr from ./mach run =. There is a null deref there, but minimal testing makes me think it is happening due to the assert.

Comment 3

[Kershaw Chang [:kershaw]]

This assertion is hit because we are trying to connect = and = is an invalid host name.
Actually, I think this assertion should be removed, since there are various of reasons that we cannot establish a connection.

Comment 4

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1768067 - Remove unneeded assert in DoSpeculativeConnectionInternal. r=kershaw

Remove the assert checking that DnsAndConnectSocket succeeded. In
DoSpeculativeConnection there are various valid reasons that this
connection may fail.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f47d305358df
Remove unneeded assert in DoSpeculativeConnectionInternal. r=kershaw,necko-reviewers

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f47d305358df