OpenPGP Key Asssistant, radio button in resolve view looks wrong
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(thunderbird_esr91 unaffected, thunderbird101 affected)
Tracking | Status | |
---|---|---|
thunderbird_esr91 | --- | unaffected |
thunderbird101 | --- | affected |
People
(Reporter: KaiE, Assigned: mkmelin)
References
Details
Attachments
(1 obsolete file)
The key assistant for bug 1627956 and bug 1767592 has a resolve view with radio buttons for chosing one of several candidates.
The intention is that the user must make an explicit decision which one should be chosen.
Therefore the dialog opens up with NO key selected initially.
This kind of works on Linux, but is broken on macOS.
On Linux, initially all unselected radio buttons are shown with a "minus" icon. Once any radio buttons is selected, the other ones go into the unselected state. This seems acceptable.
On macOS, the same icon is used for both selected and "none selected".
This means, on macOS, you initially have the impression at all radio buttons are selected, and there's no visual difference.
Is the radio button broken on macOS ? Where is the code responsible for this apperance?
Is that the code in mozilla/toolkit/content/widgets?
I briefly looked at that code - but I couldn't find relevant code.
I also couldn't find the minus icon that is shown for all-unselected. Maybe if someone could that find icon, we could try to find the related code.
If this seems like an unacceptable appearance, we could consider to use a checkbox instead - and have our own code to deselect the other checkbox, when one checkbox is clicked.
Help is wanted.
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
I think it's the same problem, just manifesting itself slightly differently on each platform.
Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
Reporter | ||
Comment 3•2 years ago
|
||
please uplift to beta
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/0a632e08e321
OpenPGP Key Asssistant, radio button in resolve view looks wrong. r=kaie
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9276643 [details]
Bug 1768153 - OpenPGP Key Asssistant, radio button in resolve view looks wrong. r=kaie
[Approval Request Comment]
User impact if declined: Acceptance radio button wrong looking/non functional
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): not risky
Comment 6•2 years ago
|
||
Comment on attachment 9276643 [details]
Bug 1768153 - OpenPGP Key Asssistant, radio button in resolve view looks wrong. r=kaie
[Triage Comment]
Approved for beta
Comment 7•2 years ago
|
||
bugherder uplift |
Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/38135d9c28f6
Assignee | ||
Comment 8•2 years ago
|
||
Based on bug 1769605, we should back this out from beta.
Comment 9•2 years ago
|
||
backout bugherder uplift |
Backout Thunderbird 101.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/92405062d78a
Updated•2 years ago
|
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Can we backout this also from trunk?
I'll take care of the styling of the key assitant in bug 1769605, but it'll take a few days.
Comment 11•2 years ago
|
||
Backout comm-central:
https://hg.mozilla.org/comm-central/rev/d7c7b693f78758910228106b461eca5e2d9d99de
Updated•2 years ago
|
Updated•2 years ago
|
Description
•