Closed
Bug 1768165
Opened 2 years ago
Closed 2 years ago
Use the new updateDetailsAndRebuild from SnapshotSelector
Categories
(Toolkit :: Places, task, P3)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
102 Branch
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(2 files)
I introduced updateDetailsAndRebuild in bug 1768164, we can replace setUrl, setUrlAndRebuildNow and setType with it... But that requires waiting for central to pine merge, remove usage from pine, then remove apis from central.
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Depends on D145733
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/14354053c08c Central-part - Remove old methods from SnapshotSelector. r=Standard8
Comment 4•2 years ago
•
|
||
Backed out changeset 14354053c08c (Bug 1768165) for causing xpcshell failures on test_snapshotselection_dedupe.js.
Backout link
Push with failures <--> X2
Failure Log
Flags: needinfo?(mak)
Assignee | ||
Comment 5•2 years ago
|
||
ah, that landed very recently, I must update the test.
Flags: needinfo?(mak)
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/9e6083b74dc3 Central-part - Remove old methods from SnapshotSelector. r=Standard8
Comment 7•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox102:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Comment 8•2 years ago
|
||
== Change summary for alert #34229 (as of Fri, 27 May 2022 15:00:46 GMT) ==
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
3% | tabswitch | windows10-64-shippable-qr | e10s fission stylo webrender-sw | 7.57 -> 7.37 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34229
You need to log in
before you can comment on or make changes to this bug.
Description
•