Use nested namespaces for mozilla/dom/**/*.h
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Tracking
(firefox102 fixed)
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
References
Details
Attachments
(47 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
Bug 1768189 - Part 41: Apply modernize-concat-nested-namespaces to dom/webgpu/BindGroup.h ... r=andi
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D145735
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D145736
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D145737
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D145738
|
|
Assignee | |
Comment 6•2 years ago
|
||
Depends on D145739
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D145740
|
|
Assignee | |
Comment 8•2 years ago
|
||
Depends on D145741
|
|
Assignee | |
Comment 9•2 years ago
|
||
Depends on D145742
|
|
Assignee | |
Comment 10•2 years ago
|
||
Depends on D145743
|
|
Assignee | |
Comment 11•2 years ago
|
||
Depends on D145744
|
|
Assignee | |
Comment 12•2 years ago
|
||
Depends on D145745
|
|
Assignee | |
Comment 13•2 years ago
|
||
Depends on D145746
|
|
Assignee | |
Comment 14•2 years ago
|
||
Depends on D145747
|
|
Assignee | |
Comment 15•2 years ago
|
||
Depends on D145748
|
|
Assignee | |
Comment 16•2 years ago
|
||
Depends on D145749
|
|
Assignee | |
Comment 17•2 years ago
|
||
Depends on D145750
|
|
Assignee | |
Comment 18•2 years ago
|
||
Depends on D145751
|
|
Assignee | |
Comment 19•2 years ago
|
||
Depends on D145752
|
|
Assignee | |
Comment 20•2 years ago
|
||
Depends on D145753
|
|
Assignee | |
Comment 21•2 years ago
|
||
Depends on D145754
|
|
Assignee | |
Comment 22•2 years ago
|
||
Depends on D145755
|
|
Assignee | |
Comment 23•2 years ago
|
||
Depends on D145756
|
|
Assignee | |
Comment 24•2 years ago
|
||
Depends on D145757
|
|
Assignee | |
Comment 25•2 years ago
|
||
Depends on D145758
|
|
Assignee | |
Comment 26•2 years ago
|
||
Depends on D145759
|
|
Assignee | |
Comment 27•2 years ago
|
||
Depends on D145760
|
|
Assignee | |
Comment 28•2 years ago
|
||
Depends on D145761
|
|
Assignee | |
Comment 29•2 years ago
|
||
Depends on D145762
|
|
Assignee | |
Comment 30•2 years ago
|
||
Depends on D145763
|
|
Assignee | |
Comment 31•2 years ago
|
||
Depends on D145764
|
|
Assignee | |
Comment 32•2 years ago
|
||
Depends on D145766
|
|
Assignee | |
Comment 33•2 years ago
|
||
Depends on D145767
|
|
Assignee | |
Comment 34•2 years ago
|
||
Depends on D145769
|
|
Assignee | |
Comment 35•2 years ago
|
||
Depends on D145770
|
|
Assignee | |
Comment 36•2 years ago
|
||
Depends on D145771
|
|
Assignee | |
Comment 37•2 years ago
|
||
Depends on D145772
|
|
Assignee | |
Comment 38•2 years ago
|
||
Depends on D145773
|
|
Assignee | |
Comment 39•2 years ago
|
||
Depends on D145774
|
|
Assignee | |
Comment 40•2 years ago
|
||
Depends on D145775
|
|
Assignee | |
Comment 41•2 years ago
|
||
Depends on D145776
|
|
Assignee | |
Comment 42•2 years ago
|
||
Depends on D145777
|
|
Assignee | |
Comment 43•2 years ago
|
||
Depends on D145778
|
|
Assignee | |
Comment 44•2 years ago
|
||
Depends on D145779
|
|
Assignee | |
Comment 45•2 years ago
|
||
Depends on D145780
|
|
Assignee | |
Comment 46•2 years ago
|
||
Depends on D145781
|
|
Assignee | |
Comment 47•2 years ago
|
||
Depends on D145782
|
||
Comment 48•2 years ago
|
||
I think you should do a single commit for all the files (or at least per component)
|
|
Assignee | |
Comment 49•2 years ago
•
|
||
The previous patch said it was hard to check whether each file had anything else in it, so I thought this would be easier to review...
|
|
||
Comment 50•2 years ago
|
||
where did you see that ?
I think it is a trivial change done by tools. I don't think it needs to be split.
|
|
Assignee | |
Comment 51•2 years ago
|
||
From https://phabricator.services.mozilla.com/D95456#3090096:
Well, it's hard to check here on Phab for the whole patch if there are other changes beyond changing to nested namespaces
|
|
||
Comment 52•2 years ago
|
||
(note that I didn't update my change back then after sg's comments ;).
anyway, if andi is fine, i am fine
|
|
Assignee | |
Comment 53•2 years ago
|
||
Sometimes some weird things may happen even when it looks like a trivial change, as in https://phabricator.services.mozilla.com/D145626#inline-803447. (Can you see what's happening there? It's puzzling to me, but still the compiler says okay)
|
|
Assignee | |
Comment 54•2 years ago
|
||
https://phabricator.services.mozilla.com/D145750#inline-804361 shows why splitting it is useful. I guess I should file a bug against clang-tidy.
|
||
Comment 55•2 years ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/73d69d82f1b2 Part 1: Apply modernize-concat-nested-namespaces to docshell/base/BrowsingContextWebProgress.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/4fa27168c345 Part 2: Apply modernize-concat-nested-namespaces to dom/base/DOMMozPromiseRequestHolder.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/31bf6f9a3f5b Part 3: Apply modernize-concat-nested-namespaces to dom/base/MessageListenerManager.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/3c60e3439717 Part 4: Apply modernize-concat-nested-namespaces to dom/base/TimeoutHandler.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/a84ff02ee83f Part 5: Apply modernize-concat-nested-namespaces to dom/base/nsNodeInfoManager.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/0bc94bbc6332 Part 6: Apply modernize-concat-nested-namespaces to dom/bindings/RootedDictionary.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/872e9ba0b25d Part 7: Apply modernize-concat-nested-namespaces to dom/cache/FileUtilsImpl.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/fbaff9f738e0 Part 8: Apply modernize-concat-nested-namespaces to dom/clients/manager/ClientHandleParent.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/080855993678 Part 9: Apply modernize-concat-nested-namespaces to dom/debugger/DebuggerNotification.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/428035a7cfed Part 10: Apply modernize-concat-nested-namespaces to dom/events/PaintRequest.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/25214e969ad9 Part 11: Apply modernize-concat-nested-namespaces to dom/filesystem/compat/CallbackRunnables.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/92c98a2fd227 Part 12: Apply modernize-concat-nested-namespaces to dom/gamepad/windows/WindowsGamepad.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/cb7c93a66422 Part 13: Apply modernize-concat-nested-namespaces to dom/html/HTMLIFrameElement.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/0c6569fe57c8 Part 14: Apply modernize-concat-nested-namespaces to dom/html/HTMLTableCellElement.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/1b98b8db84f7 Part 15: Apply modernize-concat-nested-namespaces to dom/html/nsHTMLDocument.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/e42b0d51d289 Part 17: Apply modernize-concat-nested-namespaces to dom/ipc/URLClassifierParent.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/4109e0f2fd10 Part 18: Apply modernize-concat-nested-namespaces to dom/media/PrincipalChangeObserver.h ... r=media-playback-reviewers,bryce https://hg.mozilla.org/integration/autoland/rev/9238a7890d27 Part 19: Apply modernize-concat-nested-namespaces to dom/media/gmp/GMPStorageParent.h ... r=media-playback-reviewers,bryce https://hg.mozilla.org/integration/autoland/rev/4c52f09cdd8e Part 20: Apply modernize-concat-nested-namespaces to dom/media/systemservices/CamerasParent.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/bbe4a6c1bcd8 Part 21: Apply modernize-concat-nested-namespaces to dom/media/webaudio/IIRFilterNode.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/1b336e8ecad8 Part 22: Apply modernize-concat-nested-namespaces to dom/media/webrtc/transport/ipc/WebrtcTCPSocketParent.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/0cdf0f5b071f Part 23: Apply modernize-concat-nested-namespaces to dom/network/TCPServerSocketChild.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/2930341fd302 Part 24: Apply modernize-concat-nested-namespaces to dom/performance/PerformanceNavigation.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/b8a8b2eb101f Part 25: Apply modernize-concat-nested-namespaces to dom/push/PushNotifier.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/b5879a3c56e4 Part 26: Apply modernize-concat-nested-namespaces to dom/reporting/ReportingHeader.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/3509bcca5254 Part 27: Apply modernize-concat-nested-namespaces to dom/security/featurepolicy/FeaturePolicy.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/49867efd5bce Part 28: Apply modernize-concat-nested-namespaces to dom/serviceworkers/ServiceWorkerCloneData.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/7b923414deb5 Part 29: Apply modernize-concat-nested-namespaces to dom/serviceworkers/ServiceWorkerPrivate.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/97199f4380ea Part 30: Apply modernize-concat-nested-namespaces to dom/serviceworkers/ServiceWorkerUnregisterCallback.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/34ca65c940b0 Part 31: Apply modernize-concat-nested-namespaces to dom/storage/Storage.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/66d04f6b8af9 Part 32: Apply modernize-concat-nested-namespaces to dom/svg/DOMSVGAnimatedNumberList.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/f6700b0858d2 Part 33: Apply modernize-concat-nested-namespaces to dom/svg/SVGAnimatedRect.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/d63245eb9465 Part 34: Apply modernize-concat-nested-namespaces to dom/svg/SVGFEDiffuseLightingElement.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/ac9097d988e1 Part 35: Apply modernize-concat-nested-namespaces to dom/svg/SVGFESpotLightElement.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/4a8bd96f1014 Part 36: Apply modernize-concat-nested-namespaces to dom/svg/SVGMetadataElement.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/3449b8040bb0 Part 37: Apply modernize-concat-nested-namespaces to dom/svg/SVGTSpanElement.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/7590d5fbc51b Part 38: Apply modernize-concat-nested-namespaces to dom/url/URLSearchParams.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/10e6914c13b3 Part 39: Apply modernize-concat-nested-namespaces to dom/vr/XRPose.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/809a6867cd88 Part 40: Apply modernize-concat-nested-namespaces to dom/webauthn/PublicKeyCredential.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/d9f63f176e08 Part 41: Apply modernize-concat-nested-namespaces to dom/webgpu/BindGroup.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/0b118e0c8e06 Part 42: Apply modernize-concat-nested-namespaces to dom/webgpu/RenderBundle.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/0d4cb7987807 Part 43: Apply modernize-concat-nested-namespaces to dom/workers/JSExecutionManager.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/4ab76cd7d68d Part 44: Apply modernize-concat-nested-namespaces to dom/workers/WorkerStatus.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/4078f3cb3f52 Part 45: Apply modernize-concat-nested-namespaces to dom/xhr/XMLHttpRequest.cpp ... r=andi https://hg.mozilla.org/integration/autoland/rev/6b548ee0a0a0 Part 46: Apply modernize-concat-nested-namespaces to dom/xslt/xpath/XPathResult.h ... r=andi https://hg.mozilla.org/integration/autoland/rev/f68ad4bd88bd Part 47: Apply modernize-concat-nested-namespaces to layout/style/MediaQueryList.h ... r=andi
|
||
Comment 56•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/73d69d82f1b2
https://hg.mozilla.org/mozilla-central/rev/4fa27168c345
https://hg.mozilla.org/mozilla-central/rev/31bf6f9a3f5b
https://hg.mozilla.org/mozilla-central/rev/3c60e3439717
https://hg.mozilla.org/mozilla-central/rev/a84ff02ee83f
https://hg.mozilla.org/mozilla-central/rev/0bc94bbc6332
https://hg.mozilla.org/mozilla-central/rev/872e9ba0b25d
https://hg.mozilla.org/mozilla-central/rev/fbaff9f738e0
https://hg.mozilla.org/mozilla-central/rev/080855993678
https://hg.mozilla.org/mozilla-central/rev/428035a7cfed
https://hg.mozilla.org/mozilla-central/rev/25214e969ad9
https://hg.mozilla.org/mozilla-central/rev/92c98a2fd227
https://hg.mozilla.org/mozilla-central/rev/cb7c93a66422
https://hg.mozilla.org/mozilla-central/rev/0c6569fe57c8
https://hg.mozilla.org/mozilla-central/rev/1b98b8db84f7
https://hg.mozilla.org/mozilla-central/rev/e42b0d51d289
https://hg.mozilla.org/mozilla-central/rev/4109e0f2fd10
https://hg.mozilla.org/mozilla-central/rev/9238a7890d27
https://hg.mozilla.org/mozilla-central/rev/4c52f09cdd8e
https://hg.mozilla.org/mozilla-central/rev/bbe4a6c1bcd8
https://hg.mozilla.org/mozilla-central/rev/1b336e8ecad8
https://hg.mozilla.org/mozilla-central/rev/0cdf0f5b071f
https://hg.mozilla.org/mozilla-central/rev/2930341fd302
https://hg.mozilla.org/mozilla-central/rev/b8a8b2eb101f
https://hg.mozilla.org/mozilla-central/rev/b5879a3c56e4
https://hg.mozilla.org/mozilla-central/rev/3509bcca5254
https://hg.mozilla.org/mozilla-central/rev/49867efd5bce
https://hg.mozilla.org/mozilla-central/rev/7b923414deb5
https://hg.mozilla.org/mozilla-central/rev/97199f4380ea
https://hg.mozilla.org/mozilla-central/rev/34ca65c940b0
https://hg.mozilla.org/mozilla-central/rev/66d04f6b8af9
https://hg.mozilla.org/mozilla-central/rev/f6700b0858d2
https://hg.mozilla.org/mozilla-central/rev/d63245eb9465
https://hg.mozilla.org/mozilla-central/rev/ac9097d988e1
https://hg.mozilla.org/mozilla-central/rev/4a8bd96f1014
https://hg.mozilla.org/mozilla-central/rev/3449b8040bb0
https://hg.mozilla.org/mozilla-central/rev/7590d5fbc51b
https://hg.mozilla.org/mozilla-central/rev/10e6914c13b3
https://hg.mozilla.org/mozilla-central/rev/809a6867cd88
https://hg.mozilla.org/mozilla-central/rev/d9f63f176e08
https://hg.mozilla.org/mozilla-central/rev/0b118e0c8e06
https://hg.mozilla.org/mozilla-central/rev/0d4cb7987807
https://hg.mozilla.org/mozilla-central/rev/4ab76cd7d68d
https://hg.mozilla.org/mozilla-central/rev/4078f3cb3f52
https://hg.mozilla.org/mozilla-central/rev/6b548ee0a0a0
https://hg.mozilla.org/mozilla-central/rev/f68ad4bd88bd
|
|
||
Comment 57•2 years ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b73f28686e56 Part 16: Apply modernize-concat-nested-namespaces to dom/ipc/CoalescedTouchData.h ... r=andi
|
||
Comment 58•2 years ago
|
||
| bugherder | ||
|
||
Updated•2 years ago
|
Description
•