1768193 - Partitioning tests crash the browser

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Emma Zühlcke [:emz]]

The tests at https://www.first-party.site/privacy-protections/storage-partitioning/ crash on Nightly.

Mozregression;

10:56.87 INFO: No more integration revisions, bisection finished.
10:56.87 INFO: Last good revision: 56f96e016e98d17af44a470ef6bdd07cd6d420a4
10:56.87 INFO: First bad revision: dd8df905c0a875ee8bd59303bd5bd6fbd3d5fd66
10:56.87 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=56f96e016e98d17af44a470ef6bdd07cd6d420a4&tochange=dd8df905c0a875ee8bd59303bd5bd6fbd3d5fd66

Points to Bug 1731990 and Bug 1731982.

Tim, could you take a look when you're back?

Comment 1

[Emma Zühlcke [:emz]]

Also see Twitter thread here: https://twitter.com/simevidas/status/1522325618913857536

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1731990

Comment 3

[Emma Zühlcke [:emz]]

Only affects Nightly.

Comment 4

[Pascal Chevrel:pascalc]

Should that bug block bug 1730885 ?

Comment 5

[Tim Huang[:timhuang]]

Yes, it should.

I have a patch that can fix this issue. I will submit it once it finishes.

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1768193 - Part 1: Use maybe to hold mIsThirdPartyContextToTopWindow in LoadInfo. r?#anti-tracking-reviewers,#necko-reviewers

In order to know if the mIsThirdPartyContextToTopWindow was set in the
loadInfo of the channel, we use maybe to hold the value. So, we can know
if it was set before.

This patch also addes two methods in LoadInfo to clear and know if the
value is set.

Comment 7

[Tim Huang[:timhuang]]

Attachment: Bug 1768193 - Part 2: Don't recompute IsThirdPartyToTopWindow if it was set before and there is no browsing context for the channel. r?#anti-tracking-reviewers

Depends on D146491

Comment 8

[Tim Huang[:timhuang]]

Attachment: Bug 1768193 - Part 3: Adding a test to verify loading a shared worker script in a service worker controlled third-party context won't crash. r?#anti-tracking-reviewers

Depends on D146492

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/073b3aa0decf
Part 1: Use maybe to hold mIsThirdPartyContextToTopWindow in LoadInfo. r=anti-tracking-reviewers,necko-reviewers,bvandersloot,kershaw
https://hg.mozilla.org/integration/autoland/rev/0573a72c6409
Part 2: Don't recompute IsThirdPartyToTopWindow if it was set before and there is no browsing context for the channel. r=anti-tracking-reviewers,bvandersloot
https://hg.mozilla.org/integration/autoland/rev/828c5fa96135
Part 3: Adding a test to verify loading a shared worker script in a service worker controlled third-party context won't crash. r=anti-tracking-reviewers,bvandersloot

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/073b3aa0decf
https://hg.mozilla.org/mozilla-central/rev/0573a72c6409
https://hg.mozilla.org/mozilla-central/rev/828c5fa96135