1768363 - Permissions popup does not use correct context-fill for SVG icons in dark mode

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: invisible SVG icon in permissions popup in dark mode

Tested in Thunderbird 101 Beta and Daily 2022-05-07.

When installing an addon with a SVG icon, the context-fill is not set correctly. The SVG icon is black on dark/black background, but it should be white.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

And one more thing:
When in manifest.json the SVG is not as 32px icon defined (only 64px), the addon manager uses in its addon cards a PNG icon from the addon description on ATN instead of the SVG out of the XPI, which is defined in the manifest.json. That's really confusing, but I can reproduce this in developer tools.

Comment 2

[Richard Marti (:Paenglab)]

(In reply to Alex Ihrig [:Thunderbird_Mail_DE] from comment #1)

And one more thing:
When in manifest.json the SVG is not as 32px icon defined (only 64px), the addon manager uses in its addon cards a PNG icon from the addon description on ATN instead of the SVG out of the XPI, which is defined in the manifest.json. That's really confusing, but I can reproduce this in developer tools.

Can you check if this happens on Firefox too? If yes, a dedicated bug for Firefox would be better as TB then will also be fixed because we use the same code.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Daily-popup.png

On Daily I get this. The used icon is jar:file:///.../abrufensenden_schaltflache-7.0-tb.xpi.xpi!/chrome/skin/getallmsg_fill_black_with_background.svg.

Maybe it's again the denied permission to apply -moz-context-properties: fill; on extensions.

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

Richard, please use the attached version of the addon for testing purposes.

The one (version 7.0) from ATN has defined an icon with white background as a workaround. This was necessary because of the missing context-fill in addon manager itself. But this (cards in addon manager) seems to be fixed in latest Beta and Dailies. Therefore I've been going forward and now using the context-fill SVG in version 8 of the addon.

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Addon version 8 for Thunderbird Beta 101+

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

Can you check if this happens on Firefox too?

Seems to be not possible. Installing from a file is blocked because of being not signed by AMO. And when debugging, the permissions popup is not shown.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: How it looks in latest Daily in addon manager in the addon card

I could move "forward" and use blue color for the main addon SVG like Dillinger does for its addons (see "Config Button"). But this would still be a workaround.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1768363 - Set the fill color for the popup-notification-icon. r=aleca

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f6d500d7399
Set the fill color for the popup-notification-icon. r=aleca