Closed Bug 1768370 Opened 3 years ago Closed 2 years ago

Pressing F for fullscreen in Youtube goes back to normal screen as long as "Search for text when you start typing" is enabled

Categories

(Web Compatibility :: Site Reports, defect)

Product:
Web Compatibility
Component:
Site Reports
Version:
Firefox 100
Type:
defect

Tracking

(firefox100 affected, firefox101 affected, firefox102 affected)

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox100 --- affected
firefox101 --- affected
firefox102 --- affected

People

(Reporter: onels4, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

Hello,

this is my first report and I hope I'm not wasting your time.

Since ages, when I hit F to go to fullscreen video on Youtube (the video has keyboard focus, PIP in disabled), Firefox goes to fullscreen and reverts instantly to normal video size (showing the html page). Sometimes it works only once (the first time).

Firefox 100, x64, Windows 10.

Actual results:

Hitting F while playing a Youtube video does not go to fullscreen, it displays very shortly a black (full) screen and reverts to a normal Youtube page.

Expected results:

Excepted results would be to go Fullscreen even if F is pressed (and thus making an exception for the F key) if "Search for text when you start typing" is enabled.

Sorry if this was intentionnal or normal behaviour.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:100.0) Gecko/20100101 Firefox/100.0

Hi,

I am able to reproduce the issue in release 100, beta 101 and the latest nightly 102.0a1 (2022-05-13) using Windows 10.
If this is not the correct component, feel free to change it to a more appropriate one.
This is not a recent regression, I am able to reproduce it in Fx 75 as well.
I'm not sure if this is the expected behavior or not, so I'll set it as new and waiting for the developer's opinion about it.

Thanks for the report.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
status-firefox100: --- → affected
status-firefox101: --- → affected
status-firefox102: --- → affected
Component: Untriaged → Audio/Video
Ever confirmed: true
Product: Firefox → Core

Pressing F works for me on my Ubuntu Linux in FF100.

This doesn't seem a media issue (demuxing/decoding/...) so I am going to move it to toolkit.

Component: Audio/Video → Video/Audio Controls
Product: Core → Toolkit

Thank you to both of you.

I just tried on a Firefox 91 ESR (fresh install) on Debian and there is no problem.

Given that this only happens with find-as-you-type, and the 'f' shortcut is not one relating to Firefox's builtin audio/video controls, over to a better component to investigate further...

Component: Video/Audio Controls → Find Toolbar

What's happening here is that the page is requesting that fullscreen mode be entered (via element.requestFullscreen) when the key is pressed, then find-as-you-type is opening and focusing the search field, then the line at https://searchfox.org/mozilla-central/rev/32ca4fc265150e7d3d7aa6c6abea088768cf024b/dom/base/Document.cpp#15012 returns early because the current tab isn't focused any more so it exits fullscreen again.

(In reply to Neil Deakin from comment #5)

What's happening here is that the page is requesting that fullscreen mode be entered (via element.requestFullscreen) when the key is pressed, then find-as-you-type is opening and focusing the search field, then the line at https://searchfox.org/mozilla-central/rev/32ca4fc265150e7d3d7aa6c6abea088768cf024b/dom/base/Document.cpp#15012 returns early because the current tab isn't focused any more so it exits fullscreen again.

When I looked at this briefly, it looked like the FAYT code was trying to detect if event.defaultPrevented was true. Why is that not enough to prevent this bug from happening? Are youtube perhaps doing something onkeydown and FAYT onkeypress, or something? Is there something we can improve there? :-)

Youtube doesn't call preventDefault() when a 'f' is pressed, so I would expect find-as-you-type to continue as normal.

OK, so this would need to be fixed on the youtube end.

Component: Find Toolbar → Desktop
Product: Toolkit → Web Compatibility

Thank you for the feedbacks, I'm reading all your posts even if I don't comment a lot.
Could this need to be adressed by Youtube and not Firefox ?

If I read well, Firefox is not responsible and shouldn't have a different behaviour for a specific website with it's own video controls, and Youtube is the culprit (so to speak) in this case. The focus is on the YT video component, but the FAYT takes control later, so pressing F goes first to YT then to the browser, and given they are both called one after another, one goes fullscreen and the other exits fullscreen.

Sure we can double click the video instead of pressing F with YT and it works in any case (FAYT on and off), but keyboards are life. :-)

I was not able to reproduce this issue on the latest Nightly.

Tested on:
Operating system: Windows 10
Firefox version: Nightly 111.0a1 (2023-01-16) / Chrome 108.0.5359.125

Closing this as worksforme.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME

Thank you very much !
In Firefox 108.2 stable the issue remains. I updated to 109 stable and if the video component has focus, there is no issue. Perfect !

Thank you for closing.

FWIW I can still reproduce this on nightly with accessibility.typeaheadfind set to true, depending on where focus is on youtube. I don't normally set that pref so I don't have a horse in this race, but I don't think anything happened to fix this - it requires a fix from youtube, and if they did fix it it'd fix it for all Firefox versions.

You need to log in before you can comment on or make changes to this bug.