[wpt-sync] Sync PR 33991 - Update accessibility subtree when an event listener is removed
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox102 fixed)
Tracking | Status | |
---|---|---|
firefox102 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33991 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33991
Details from upstream follow.
Joanmarie Diggs <jdiggs@igalia.com> wrote:
Update accessibility subtree when an event listener is removed
If an object was included in the accessibility tree solely due to an
event listener which was just removed, that object will be marked as
dirty and subsequently as ignored. When BlinkAXTreeSource::GetChildren
is then called due to serialization of updates and events, the parent of
that now-ignored object will have a child it should not and a DCHECK
will fail.This commit solves that problem by calling ChildrenChangedOnAncestorOf
if the event listener was removed on an existing AXObject. Doing so
causes the accessibility tree to be updated prior to serialization of
updates and events. It includes an additional change and test from
crrev.com/c/3608668.AX-Relnotes: N/A
Bug: 1319933
Change-Id: Ibb4b78d480d940c8274db75b3739cda0e253933e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614009
Reviewed-by: Aaron Leventhal \<aleventhal@chromium.org>
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Joanmarie Diggs \<jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#997215}
Assignee | ||
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c1c9ff142a048d8c04642f4fd845c3e8a54ee85
Assignee | ||
Comment 2•2 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS
: 1
Chrome
PASS
: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/33e2b0dd18c2 [wpt PR 33991] - Update accessibility subtree when an event listener is removed, a=testonly
Comment 4•2 years ago
|
||
bugherder |
Description
•