1768428 - AttributeError raised in `js/moz.configure` (`wasm_verify_serialization_for_size`) when running `./mach build` with `--enable-debug`

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P1)

Description

[William Durand [:willdurand]]

On Linux, I ran into a build error when trying to build FF Desktop in artifact mode with debug enabled (it works when debug isn't enabled). Here is my mozconfig:

# Automatically download and use compiled C++ components:
ac_add_options --enable-artifact-builds

# Enable debug versions of the pre-built binary artifacts:
ac_add_options --enable-debug

Running ./mach build produces this stack trace:

 [...]
 0:01.78 checking for Python 3... /workspace/gitpod-firefox-dev/mozilla-unified/obj-x86_64-pc-linux-gnu/_virtualenvs/build/bin/python (3.8.13)
 0:01.78 checking for git... /usr/bin/git
 0:01.78 checking for Git version... 2.35.1
 0:01.80 checking for sparse checkout... no
 0:03.49 checking for wget... /usr/bin/wget
 0:03.54 Traceback (most recent call last):
 0:03.54   File "/workspace/gitpod-firefox-dev/mozilla-unified/configure.py", line 349, in <module>
 0:03.54     sys.exit(main(sys.argv))
 0:03.54   File "/workspace/gitpod-firefox-dev/mozilla-unified/configure.py", line 131, in main
 0:03.54     sandbox.run(os.path.join(os.path.dirname(__file__), "moz.configure"))
 0:03.54   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 567, in run
 0:03.54     func(*args)
 0:03.54   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 618, in _value_for
 0:03.55     return self._value_for_depends(obj)
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/util.py", line 1061, in method_call
 0:03.55     cache[args] = self.func(instance, *args)
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 627, in _value_for_depends
 0:03.55     value = obj.result()
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/util.py", line 1061, in method_call
 0:03.55     cache[args] = self.func(instance, *args)
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 163, in result
 0:03.55     return self._func(*resolved_args)
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/python/mozbuild/mozbuild/configure/__init__.py", line 1310, in wrapped
 0:03.55     return new_func(*args, **kwargs)
 0:03.55   File "/workspace/gitpod-firefox-dev/mozilla-unified/js/moz.configure", line 849, in wasm_verify_serialization_for_size
 0:03.55     and c_compiler.type == "clang"
 0:03.55 AttributeError: 'NoneType' object has no attribute 'type'
*** Fix above errors and then restart with "./mach build"

It looks like the wasm_verify_serialization_for_size function has been added in https://phabricator.services.mozilla.com/D144585

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1768428 - Check that `c_compiler` is defined in `wasm_verify_serialization_for_size`. r?rhunt!

c_compiler appears to be undefined when we use artifact + debug mode.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3204ddf7f056
Check that `c_compiler` is defined in `wasm_verify_serialization_for_size`. r=rhunt

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3204ddf7f056

Comment 6

[Intermittent Failures Robot]

1 failures in 3317 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 1

Platform and build breakdown:

• linux64: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1768428&startday=2022-05-09&endday=2022-05-15&tree=all