1768436 - The subtitles from PiP move up and down when modifying PiP's size while buttons are still displayed

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Daniel Bodea [:danibodea]]

Attachment: subs move u and down when modifying the PiP size with buttons displayed.webm

Note

• When the user watches a video in PiP with subtitles and he modifies the size of the PiP while the buttons are still displayed, he will notice that the subtitles will move up and down.

Affected versions

• Nightly v102.0a1
• Beta v101.0b3
• Release

Affected platforms

• all

Steps to reproduce

1. Launch browser.
2. Load a YT video with subs (ex)
3. Activate captions/subs.
4. Launch PiP.
5. Pause the video with a subtitle on screen.
6. Modify its size.

Expected result

• The subtitle text will remain in place (relative to the PiP window) and will shrink/enlarge, based on the size of the PiP.

Actual result

• The subtitles move up and down (temporarily). This is an aestetic issue.

Regression range

• Not a recent regression.

Additional notes

• This issue also occurs while the video is playing, but it's easier to reproduce it while on pause.

Comment 1

[kpatenio]

Janvi expressed interest in this ticket, so I'm marking her as an assignee

Comment 2

[Janvi Bajoria [:janvi01]]

Thanks for assigning it @kpatenio

Comment 3

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1768436 - fixed PIP subtitles move up and down r=kpatenio,niklas

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e65926b7b29
fixed PIP subtitles move up and down r=kpatenio

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8e65926b7b29

Comment 6

[Ina Popescu, Desktop QA]

I've reproduced the issue on Nightly 102.0a1 on Windows 10 using the STR from Comment 0.
Verified as fixed on Firefox 109.0b2 on Windows 10, macOS 12 and Ubuntu 22.04.