1768450 - Pressing "Esc" does not exit PiP fullscreen on Mac

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect, P2)

Description

[Peter Magyari (Desktop QA)]

Affected versions

• ESR 91.8.0
• Release 100.0
• Beta 101.0b4
• Nightly 102.0a1

Affected platforms

• MacOS 11.6
• MacOS 12.0.1

Steps to reproduce

1. Launch Firefox.
2. Go to https://www.youtube.com/watch?v=VJI88QIW7H4
3. Launch Picture-in-Picture mode (Ctrl+Shift+]) and double click the PiP window to make it full-screen.
4. Press "Esc" to exit PiP full-screen.

Expected result

• PiP full-screen gets minimized and the playback continues in the PiP window.

Actual result

• Pressing "Esc" does not do anything.

Comment 1

[kpatenio]

I can confirm this issue on MacOS 11.6 with the latest Nightly version. I am able to work around it though by clicking on the PiP full-screen window and then pressing the Esc key. The Esc keydown event is probably not detected since the PiP full-screen does not have focus when we first enter full-screen mode.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1768450 - Focus the window when PiP is fullscreened. r=#pip-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a0b1bdc751f
Focus the window when PiP is fullscreened. r=pip-reviewers,kpatenio

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2a0b1bdc751f

Comment 5

[Peter Magyari (Desktop QA)]

I've verified the fix on MacOS 11.6 and MacOS 12 using Nightly 103.0a1 (20220605213032)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.