1768678 - FF100 CSS Text Shadow - bad dirty rough text shadow

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[alex-ka19]

Steps to reproduce:

example:
https://codepen.io/pen/rNpdMWL

Actual results:

FF100 and FF99 css text shadow has become dirty, in FF98 there was no such thing

(css: text-shadow: 0 0 20px;)

Expected results:

Please check

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Layout: Text and Fonts' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mayank Bansal]

On the latest Nightly, I see flickering of the text shadows.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6f1243c3ba45a4ad3cfd1cacdbf12ad377b4a81&tochange=fc2b3d6448bcc3575fffb1abc923e7e703aeef54

Comment 4

[Mayank Bansal]

Attachment: Testcase.html

standalone testcase

Comment 5

[BugBot [:suhaib / :marco]]

:gw, since you are the author of the regressor, bug 1749380, could you take a look?
For more information, please visit auto_nag documentation.

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Glenn, could you set a severity to this bug? Is that something we could fix in 102? Thanks

Comment 7

[Glenn Watson [:gw]]

I'm unlikely to have time to look at it in the next couple of weeks.

Comment 8

[Glenn Watson [:gw]]

Attachment: Bug 1768678 - Fix blur source size adjustment for downscaling

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f93a246366f
Fix blur source size adjustment for downscaling r=gfx-reviewers,lsalzman

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9f93a246366f

Comment 11

[Mayank Bansal]

This is fixed in latest nightly

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta and ESR102 approval when you get a chance.

Comment 13

[Glenn Watson [:gw]]

Comment on attachment 9286169 [details]
Bug 1768678 - Fix blur source size adjustment for downscaling

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Suggested by RyanVM as a quality improvement.
• User impact if declined: Artifacts on blurs, especially animated ones.
• Fix Landed on Version: 105?
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Clear bug fix, small patch.

Beta/Release Uplift Approval Request

• User impact if declined: Artifacts on blurs, especially animated ones.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Clear bug fix, small patch.
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Dianna Smith [:diannaS]]

Comment on attachment 9286169 [details]
Bug 1768678 - Fix blur source size adjustment for downscaling

Approved for 104.b3

Comment 15

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9b888573704b

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9286169 [details]
Bug 1768678 - Fix blur source size adjustment for downscaling

Approved for 102.2esr.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/219f05219b4c