Closed Bug 1768679 Opened 2 years ago Closed 2 years ago

Report alternative output stream size on about:cache disk cache page

Categories

(Core :: General, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: bthrall, Assigned: bthrall)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The about:cache?storage=disk page reports "Data size" but this is the total data size of the cache entry. For JavaScript scripts, the data is divided into source and bytecode, and it would help us see the effects of bytecode caching and other bytecode generation effects directly on this page.

The about:cache?storage=disk page should show the "Total Data size" and, if it isn't zero, the "Alternative Data size" and the "Data size".

Regarding the format of the alternative data size on about:cache, @dragana said (in Matrix):

I do not have a strong opinion on this. I think adding a new column is more understandable. I do not think we need the total size.

Attachment #9276741 - Attachment description: WIP: Bug 1768679 - Add 'Alt Data size' column to about:cache → Bug 1768679 - Add 'Alt Data size' column to about:cache r?arai
Attachment #9276741 - Attachment description: Bug 1768679 - Add 'Alt Data size' column to about:cache r?arai → Bug 1768679 - Add 'Alt Data size' column to about:cache r?dragana

The value is stored as uint32_t, and there doesn't seem to be a need to convert
it to int.

Pushed by bthrall@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb1a72f69807
Expose cache fetch count as uint32_t r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/c566946bd248
Add 'Alt Data size' column to about:cache r=necko-reviewers,dragana
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: