Closed Bug 1768681 Opened 2 years ago Closed 2 years ago

Create a "loading" state for the tab pickup section of Firefox View

Categories

(Firefox :: Sync, enhancement)

Desktop
All
enhancement
Points:
3

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox102 --- wontfix
firefox103 --- fixed

People

(Reporter: Gijs, Assigned: sfoster)

References

Details

(Whiteboard: [fidefe-2022-mr1-myfirefox])

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
  • Move loading.svg to toolkit/themes/shared/icons
  • Add license and the context-fill attribute to the svg file
  • Adjust the --loading-icon CSS variable to point to the new chrome:// URL for the icon
  • Set context-fill to the currentColor, so the SVG fill will adjust to dark/light/whatever themes
  • Removing loading-dark.svg which is no longer necessary
  • Add loading state strings and update string from previous steps
  • Show a loading/syncing step when the last tab sync was greater than 30s ago
  • Change the loading state to hide the setup steps and show the tabs list with a loading spinner

Depends on D147563

Attachment #9278580 - Attachment is obsolete: true
Attachment #9278585 - Attachment description: Bug 1768681 - Part2: Implement a loading state for tabs-pickup while we wait for remote tabs to sync. r?Gijs! → Bug 1768681 - Implement a loading state for tabs-pickup while we wait for remote tabs to sync. r?Dao!
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07d862465440
Implement a loading state for tabs-pickup while we wait for remote tabs to sync. r=fluent-reviewers,desktop-theme-reviewers,dao,Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Depends on: 1779204
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: