1768686 - [wpt-sync] Sync PR 34021 - Only reflect valid popup values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 34021 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34021
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Only reflect valid popup values

This was resolved in [1] - only valid values for the popup attribute
should be reflected, so that feature detection can be used on the values.

[1] https://github.com/openui/open-ui/issues/491#issuecomment-1118927375

Bug: 1307772
Change-Id: I932a28bd48e336cf01253a971804dc00dcd099fa
Reviewed-on: https://chromium-review.googlesource.com/3639122
WPT-Export-Revision: e09ac97a3172b2d6acbe010631059b188f6cc8ce

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff0aa5e8e1ebf5950fe92718cbcb1b644a25173e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

OK : 1
FAIL: 13

Chrome

OK : 1
PASS: 12
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popups/popup-attribute-basic.tentative.html [wpt.fyi]
  • The .showPopup() and .hidePopup() work on a popup, case #0.: FAIL (Chrome: PASS)
  • The .showPopup() and .hidePopup() work on a popup, case #1.: FAIL (Chrome: PASS)
  • The .showPopup() and .hidePopup() work on a popup, case #2.: FAIL (Chrome: PASS)
  • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #0.: FAIL (Chrome: PASS)
  • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #1.: FAIL (Chrome: PASS)
  • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, case #2.: FAIL (Chrome: PASS)
  • IDL attribute reflection: FAIL (Chrome: FAIL)
  • Popup attribute value should be case insensitive: FAIL (Chrome: PASS)
  • Changing attribute values for popup should work: FAIL (Chrome: PASS)
  • Changing attribute values should close open popups: FAIL (Chrome: PASS)
  • Removing a visible popup=popup element from the document should close the popup: FAIL (Chrome: PASS)
  • Removing a visible popup=hint element from the document should close the popup: FAIL (Chrome: PASS)
  • Removing a visible popup=async element from the document should close the popup: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8afb54f99e4a
[wpt PR 34021] - Only reflect valid popup values, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8afb54f99e4a