1768750 - Zoom indicator in URL bar does not get focus outline

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. Launch FF, go to google.com
2. Change the zoom level from the default zoom with cmd/ctrl + or cmd/ctrl -
3. Focus the URL bar with cmd/ctrl + L
4. Hit tab

Expected: the zoom indicator receives a focus outline
Actual: no focus outline is drawn

I ran mozregression, which pointed me here: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6c069b46b57f9ef2da16aa9487a6f7544507b212&tochange=91956f62a123375565ab58f96f50b6245dd381b8

Comment 1

[Morgan Reschenberg [:morgan]]

dao, do you know why this happened? your previous patch seems fairly straightforward

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1757572

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9276034 [details]
Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Beta/Release Uplift Approval Request

• User impact if declined: See comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c2ed6d4b61
Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9276034 [details]
Bug 1768750 - Replace stray reference to --toolbarbutton-focus-outline. r=morgan

Approved for 101.0b6.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb2524001bfd

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/17c2ed6d4b61

Comment 9

[Giorgia Nichita, Release Desktop QA]

I have reproduced this issue on an affected Nightly build from 2022-05-21, on Win 10 x64.
Verified as fixed on Firefox 101.0b7 (20220515185854) and Firefox 102.0a1 (20220516095144) on Windows 10 x64, macOS 10.14 and Ubuntu 21.04.