Closed Bug 1768784 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34024 - Reland "CSS highlight painting: bump HighlightOverlayPainting to stable"

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34024 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34024
Details from upstream follow.

Delan Azabani <dazabani@igalia.com> wrote:

Reland "CSS highlight painting: bump HighlightOverlayPainting to stable"

This is a reland of commit abc6f616c7bc2c53cc9d8c44b82384d43dd77d02

Original change's description:

CSS highlight painting: bump HighlightOverlayPainting to stable

This patch enables the new highlight overlay painter. The rebaselined
tests and their reasons are as follows:

• no more double painting bug
• dark-mode/colors/selection.html
• originating decorations are now recolored per spec
• editing/selection/line-wrap-2.html
• virtual/text-antialias/selection/khmer-selection.html
• spelling markers are now consistently painted over text
• paint/markers/document-markers-font-8px.html
• paint/markers/document-markers-zoom-2000.html
• decorations are now clipped to highlight background rect
• svg/text/text-selection-deco-01-b.svg
• svg/text/text-selection-text-03-b.svg

The only new failure expectations are as follows:

• external/wpt/css/css-pseudo/highlight-painting-003.html broadens
from Mac11 to Mac (like we had to do in CL:3608432)
• external/wpt/css/css-text-decor/text-decoration-color-selection-001
fails because the test is incorrect (bug 1321106)
• paint/markers/suggestion-marker-basic.html fails because it’s not
clear the assertion still complies with the spec (bug 1321114)

Some tests had bugs that we’ve fixed in this patch:

• external/wpt/css/css-pseudo/target-text-text-decoration-001.html
had a bug where it assumed UA default highlight colors would be
suppressed by an author ‘text-decoration’

Bug: 1147859
Change-Id: Ie4d8dae515a786fa01e8f2852d645f3a8ad313be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616170
Reviewed-by: Stephen Chenney \<schenney@chromium.org>
Commit-Queue: Delan Azabani \<dazabani@igalia.com>
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1001604}

Bug: 1147859
Change-Id: Icd150ff8c695d20a5c9f44df45d5e0751c31f79a
Reviewed-on: https://chromium-review.googlesource.com/3640642
WPT-Export-Revision: ace43026e705788bdf7d8dfe408766ffb9e17ee9

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/801234568ab0
[wpt PR 34024] - Reland "CSS highlight painting: bump HighlightOverlayPainting to stable", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.