Closed Bug 1768795 Opened 2 years ago Closed 6 days ago

Make nsTerminator shutdown phase duration measure become wall-clock based

Categories

(Toolkit :: Async Tooling, task, P3)

task

Tracking

()

RESOLVED WONTFIX

People

(Reporter: jstutte, Unassigned)

References

Details

Attachments

(1 obsolete file)

Currently nsTerminator::RunWatchdog counts ticks while looping, assuming that the effective duration of the sleep is approximately similar to the requested one.

In particular under MacOS (but also Windows) the effective duration of each loop run seems to be largely varying and tending to last significantly longer, up to 50%, it seems.

We could substitute the counter with a wall-clock based effective-ms-passed measurement at each loop run (and re-transform this into ticks).

Component: XPCOM → Async Tooling
Keywords: good-first-bug
Product: Core → Toolkit
See Also: → 1766572
Severity: -- → S4
Priority: -- → P3
Assignee: nobody → jstutte
Status: NEW → ASSIGNED
Blocks: 1760094
Attachment #9362153 - Attachment description: Bug 1768795 - Adjust passed ticks to wall-clock after each sleep. r?gijs → Bug 1768795 - Adjust passed ticks to wall-clock after each sleep. r?nika
Attachment #9362153 - Attachment is obsolete: true
Assignee: jstutte → nobody
Status: ASSIGNED → NEW

Removing good-first-bug until we decide, if we really want to do this. For now I propose to just adjust the failing test on bug 1760094.

No longer blocks: 1760094
Keywords: good-first-bug
See Also: → 1760094
See Also: → 1879136

We decided in bug 1879136 to remove the telemetry. We still measure the ticks, but the value is actually not visible anywhere (and we might eventually want to remove the measurement entirely).

Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: