1769057 - Add WritableFileStream support to OPFS

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

The OPFS spec includes WritableFileStream (based on WritableStream) via createWritable().

Note that this requires copy-on-open and replace-on-close semantics.

It also must take a read lock (which is supported in the OPFS code) so you can't have WritableFileStreams open on the same file as an SyncAccessHandle has open.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1769057: WritableFileStream for OPFS implementation r=saschanaz,#dom-storage-reviewers

Comment 2

[Jan Varga [:janv]]

(In reply to Randell Jesup [:jesup] (needinfo me) from comment #0)

Note that this requires copy-on-open and replace-on-close semantics.

So, are we going to implement this ?

Comment 3

[Jari Jalkanen]

Attachment: Bug 1769057 - Close parent side file handles to unlock child side. r=#dom-storage,jesup

Comment 4

[Jari Jalkanen]

Attachment: Bug 1769057 - Fix static analysis issues. r=#dom-storage-reviewers

Comment 5

[Phabricator Automation]

Comment on attachment 9296739 [details]
Bug 1769057 - Close parent side file handles to unlock child side. r=#dom-storage,jesup

Revision D158405 was moved to bug 1798459. Setting attachment 9296739 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e450859e6f0a
WritableFileStream for OPFS implementation r=janv,webidl,dom-storage-reviewers,smaug
https://hg.mozilla.org/integration/autoland/rev/5ad098d5b4b9
Fix static analysis issues. r=dom-storage-reviewers,janv

Comment 7

[Atila Butkovits]

Backed out for causing failures at fs/FileSystemBaseHandle-IndexedDB.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1576f7f93a3cb5eecdcae6118dad5f97a4904a05

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=XNZhKi7gTkag7NZ67rv8pA.0&resultStatus=testfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx86%2C2004%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows10-32-2004-qr%2Fopt-web-platform-tests%2Cwpt2&revision=d920e7aa41126a6c378ac92aebf282ebd071659a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=395997253&repo=autoland&lineNumber=8047

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c43c77f85e62
WritableFileStream for OPFS implementation r=janv,webidl,dom-storage-reviewers,smaug
https://hg.mozilla.org/integration/autoland/rev/0e2e808b9542
Fix static analysis issues. r=dom-storage-reviewers,janv

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c43c77f85e62
https://hg.mozilla.org/mozilla-central/rev/0e2e808b9542