1769113 - Kill off nsIPrintingPromptService and use nsIPrintDialogService directly

Status: RESOLVED FIXED

(Core :: Printing: Setup, task)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1769113 - Kill off nsIPrintingPromptService and use nsIPrintDialogService directly. r=emilio

nsIPrintingPromptService comes from an era when the platform print code would
open the print settings dialog, which defaulted to the OS native dialogs.
Its purpose was to allow that dialog to be overridden by embedders to provide
their own interface for the user to select print settings. Nowadays the
platform print code does not open the dialogs. Instead apps like Firefox are
responsible for getting the print settings to pass to the platform code, and
the platform code provides a way to open the OS native print dialog if they
want to use that (nsIPrintDialogService). So nsIPrintingPromptService no longer
has any purpose, and just adds indirection and needless complexity.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

FYI I think TB will need to change https://searchfox.org/comm-central/rev/cb066c59205002a0b0ac64a72e9ac2313acef39c/mail/base/content/mail3PaneWindowCommands.js#1606 in a similar fashion as comment 1 does for the Firefox printing code.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1769113 - use nsIPrintDialogService directly in Thunderbird. r=#thunderbird-reviewers

Comment 4

[Magnus Melin [:mkmelin]]

Thanks for the heads up!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a8b46329956
Kill off nsIPrintingPromptService and use nsIPrintDialogService directly. r=emilio

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7a8b46329956

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bda126269442
use nsIPrintDialogService directly in Thunderbird. r=lasana