Closed Bug 1769121 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34047 - [@container] Support container-relative units in gradients

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34047 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34047
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Support container-relative units in gradients

Units in gradients are resolved outside of style resolution, using a
separate CSSToLengthConversionData object. (The main object being part
of StyleResolverState). At the time the gradients are produced, we don't
have enough context to pass the nearest container to the
CSSToLengthConversionData constructor.

This CL solves that by eagerly fetching container sizes during
ElementStyleResources::LoadPendingResources, and storing those sizes
on StyleGeneratedImage (which is created during style resolution).

Note that invalidation does not work yet.

Bug: 1223030, 1313084
Change-Id: I2373bca3dbadb9129975f62b49c15e5631a033e6
Reviewed-on: https://chromium-review.googlesource.com/3645211
WPT-Export-Revision: f1d4229281fe57647dadb639ccab1c2a9deb635a

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c50b1ae8ed5
[wpt PR 34047] - [@container] Support container-relative units in gradients, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8e640a8ee02c
[wpt PR 34047] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7c50b1ae8ed5
https://hg.mozilla.org/mozilla-central/rev/8e640a8ee02c

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.