Closed Bug 1769124 Opened 2 years ago Closed 2 years ago

Actually require `Recv` methods to return IPCResult

Categories

(Core :: IPC, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: nika, Assigned: nika)

Details

Attachments

(1 file)

I noticed when reviewing some patches that apparently our generated IPDL code doesn't actually require that IPDL RecvXXX() methods return IPCResult due to devirtualization, and just checks them using the implicit operator bool() conversion, meaning that any type which can be implicitly converted to bool can be returned from a Recv method without causing a compile error.

This bug tracks changing this to actually require users to use the IPCResult type when returning from these functions.

Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4cfe3fd62e6c
Require Recv methods to return IPCResult, r=ipc-reviewers,mccr8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: