1769189 - replaceState does not work in beforeunload listener

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[sam9072000]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:100.0) Gecko/20100101 Firefox/100.0

Steps to reproduce:

• Include this script into a simple html page

console.log(window.history.state);
window.addEventListener('beforeunload', () => {
  window.history.replaceState({ data: true }, '');
});

• Visit page
• Press refresh button to refresh page

Actual results:

• After refreshing the page with the refresh button, the console prints null.

Expected results:

• After refreshing the page with the refresh button, the console should print {data: true}

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Is this a regression? In other words, did this work before?

(I'm not even sure this is a bug.)

The bug title isn't quite right though. beforeunload is triggered, it is just that calling replaceState so late doesn't do anything.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Ok, this is a SHIP regression.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1769189, ensure history state is updated if beforeunload listener calls replaceState, r=peterv

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7111ffbafc64
ensure history state is updated if beforeunload listener calls replaceState, r=peterv

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7111ffbafc64