Closed Bug 1769281 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34059 - [floats] Add logic to ensure we don't intersect floats.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34059 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34059
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[floats] Add logic to ensure we don't intersect floats.

Previously with certain values of margins - it was possible to create
a scenario to intersect a new-fc with a float.

As demonstrated by: floats-wrap-bfc-with-margin-003.tentative.html

This patch introduces logic to prevent this. Specifically after we have
calculated the BFC-offset for the new formatting context, we check
if it is outside the opportunity on each side, and if that side of the
opportunity has any floats.

Bug: 1323004, 1322774
Change-Id: I82e07e6568da92a3e73842f54347c4f07ec73f51
Reviewed-on: https://chromium-review.googlesource.com/3636486
WPT-Export-Revision: 7f6a959fae7ef85db9287daecfb93f8b97d82556

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

FAIL: 2

Safari

FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c169f210bf
[wpt PR 34059] - [floats] Add logic to ensure we don't intersect floats., a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.