Closed Bug 1769296 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 34060 - Revert "[Trusted Types] Get list of event handlers from WebIDL"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox102 fixed)

RESOLVED FIXED
102 Branch
Tracking Status
firefox102 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34060 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34060
Details from upstream follow.

David Song <wintermelons@google.com> wrote:

Revert "[Trusted Types] Get list of event handlers from WebIDL"

This reverts commit 20acdd57bc0c2900456a9717629834686cdb4890.

Reason for revert: Breaks Deterministic builders on debug builds, likely due to the Python build action.

Linux failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux%20(dbg)/25817/overview
Fuchsia failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Fuchsia%20(dbg)/12090/overview

Original change's description:

[Trusted Types] Get list of event handlers from WebIDL

This change retrieves the list of attributes declared as event handlers
from WebIDL and uses that to check for TrustedScript, instead of using
the string prefix "on".

Bug: 993268, 1084587
Change-Id: Ic15bc0994bcd19d9d7385cbef4af0f01af820ae1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3616765
Reviewed-by: Mason Freed \<masonf@chromium.org>
Reviewed-by: Yuki Shiino \<yukishiino@chromium.org>
Reviewed-by: Yifan Luo \<lyf@chromium.org>
Commit-Queue: Daniel Vogelheim \<vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1003034}

Bug: 993268, 1084587
Change-Id: I0ba65a80617dd027eb7903192843fa8700a4c56a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648222
Commit-Queue: Dale Curtis \<dalecurtis@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Dale Curtis \<dalecurtis@chromium.org>
Auto-Submit: David Song \<wintermelons@google.com>
Reviewed-by: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1003215}

PR 34060 applied with additional changes from upstream: 559b045ea2d51a44b901f4d6b8b1baa94e633049
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e408e4a31ca
[wpt PR 34060] - Revert "[Trusted Types] Get list of event handlers from WebIDL", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.