1769322 - Allow for the possibility of non-xpc globals in nsIGlobal::IsScriptForbidden

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

nsIGlobalObject::isScriptForbidden assumes that unless you've got an interface implemented in JS, your global is an xpc global, and therefore will have RealmPrivate + Scriptability.

This is a problem for ShadowRealms, as we can end up with callbacks from inside the ShadowRealm, where before executing the callback we check "IsScriptForbidden()`, and the shadow realm global is currently defined as a WebIDL global (and unlike all the other WebIDL defined globals, I think, can appear on main thread).

I think the fix here is simply to teach this that not all globals can return this data.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1769322 - Allow for the possibility of non-xpc globals in nsIGlobal::IsScriptForbidden r?smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/018450d728de
Allow for the possibility of non-xpc globals in nsIGlobal::IsScriptForbidden r=smaug

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/018450d728de