1769405 - mach bootstrap should check the mismatch between the default mozconfig file and the selected build target

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, task)

Description

[Tooru Fujisawa [:arai]]

Bug 1632874 introduced the feature to automatically generate the default mozconfig file for the selected build target,
but that causes confusion in the following scenario:

1. run bootstrap.py
2. select "Firefox for Desktop Artifact Mode"
3. run ./mach build and get artifact build
4. run ./mach bootstrap
5. select "Firefox for Desktop"
6. run ./mach build, but still get artifact build

the issue is that, the mozconfig file for browser_artifact_mode is automatically generated at step 2,
but the config is not updated at step 5,
and also no message is shown because the expected mozconfig is empty

Comment 1

[Tooru Fujisawa [:arai]]

Possible options are:

1. automatically rewrite the default mozconfig for basic case (browser vs browser_artifact_mode)
2. warn about the mismatch
3. add yet another mozconfig file path (e.g. mozconfig.bootstrap-generated) that's managed by bootstrap, and use it only when no other mozconfig is found, and always rewrite the file for the selected target

Comment 2

[Tooru Fujisawa [:arai]]

Also, if the config is automatically rewritten, it's better using different MOZ_OBJDIR between artifact mode and non-artifact mode

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769405 - Part 4: Detect mismatch between the default mozconfig and the selected build target. r?#firefox-build-system-reviewers!

When ./mach bootstrap is called with the default mozconfig file,
verify the content matches the selected build target, and if not,
show a warning and ask whether to overwrite or not.

Comment 4

[Tooru Fujisawa [:arai]]

I'll take basically 2, with proposing the overwrite (y/n question), not automatically.

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769405 - Part 1: Move artifact build option to build/moz.configure/init.configure. r?glandium!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769405 - Part 3: Return project and artifact-builds options from MozbuildObject.get_base_mozconfig_info. r?glandium!

Depends on D147011

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769405 - Part 2: Rename mozconfig_and_target to base_mozconfig_info and return dictionary. r?glandium!

Depends on D147011

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f8e0141a0ed
Part 1: Move artifact build option to build/moz.configure/init.configure. r=glandium
https://hg.mozilla.org/integration/autoland/rev/9099ba749b1f
Part 2: Rename mozconfig_and_target to base_mozconfig_info and return dictionary. r=glandium
https://hg.mozilla.org/integration/autoland/rev/6de9495c467d
Part 3: Return project and artifact-builds options from MozbuildObject.get_base_mozconfig_info. r=glandium
https://hg.mozilla.org/integration/autoland/rev/813147df341c
Part 4: Detect mismatch between the default mozconfig and the selected build target. r=firefox-build-system-reviewers,glandium

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5f8e0141a0ed
https://hg.mozilla.org/mozilla-central/rev/9099ba749b1f
https://hg.mozilla.org/mozilla-central/rev/6de9495c467d
https://hg.mozilla.org/mozilla-central/rev/813147df341c

Comment 10

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1769405) for causing regression in Bug 1774100.
Backout link

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24720e4b2531
Part 1: Move artifact build option to build/moz.configure/init.configure. r=glandium
https://hg.mozilla.org/integration/autoland/rev/014b13c05e48
Part 2: Rename mozconfig_and_target to base_mozconfig_info and return dictionary. r=glandium
https://hg.mozilla.org/integration/autoland/rev/b998b1a573f8
Part 3: Return project and artifact-builds options from MozbuildObject.get_base_mozconfig_info. r=glandium
https://hg.mozilla.org/integration/autoland/rev/16420ba4d291
Part 4: Detect mismatch between the default mozconfig and the selected build target. r=firefox-build-system-reviewers,glandium

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/24720e4b2531
https://hg.mozilla.org/mozilla-central/rev/014b13c05e48
https://hg.mozilla.org/mozilla-central/rev/b998b1a573f8
https://hg.mozilla.org/mozilla-central/rev/16420ba4d291