1769437 - browser_userContextId_openWindow.js fails

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P3)

Description

[Andrew McCreight [:mccr8]]

dom/serviceworkers/test/browser_userContextId_openWindow.js fails when run with the following failure:

FAIL New tab has UCI equal 3 - Got "3", expected 3

Under some condition, a property is being set as a string when we expect it to be an integer.

I don't know if the test is wrong or the behavior is wrong. This failure doesn't show up because it isn't run if serviceworker_e10s is true, and it is always true (except in verify mode, sometimes, for some reason, which I filed bug 1769436 about).

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1769437 - Adjust to expect a string attribute r=asuth,mccr8

I don't know how it returned a number before, but in 2024 newTab is an Element where getAttribute() is expected to only return a string.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b86a4e395d5d
Adjust to expect a string attribute r=asuth

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b86a4e395d5d