1769451 - Fix missing include in public headers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

bug 1768634 is caused by missing include in the SpiderMonkey public header.

we'd better verifying each header can be included alone.
I'm thinking about adding autospider variant that automatically generates cpp files for each public header and build them, in the same way as nonunified variant modifies moz.build.

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)

bug 1768634 is caused by missing include in the SpiderMonkey public header.

maybe something different, or it's more complex case.
#include "js/ProtoKey.h" compiles without modifying the file.

anyway, it found 4 public header files that needs more #include.

Comment 2

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #1)

(In reply to Tooru Fujisawa [:arai] from comment #0)

bug 1768634 is caused by missing include in the SpiderMonkey public header.

maybe something different, or it's more complex case.
#include "js/ProtoKey.h" compiles without modifying the file.

ProtoKey.h defines the macro, so it needs consumer to hit the issue.
in bug 1768634, it's jspubtd.h, but #include "jspubtd.h" compiles here.
maybe there's behavior difference between clang and MSVC?

Comment 3

[Tooru Fujisawa [:arai]]

bug 1768634 is caused by the preprocessor behavior difference, so not related to #include.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769451 - Part 1: Fix missing include in js/public. r=sfink

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1769451 - Part 2: Add autospider variant for checking header r=sfink!

Depends on D146611

Comment 6

[Tooru Fujisawa [:arai]]

IWYU isn't actually enforced by the script. what it verifies is that there's no missing include.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00441393b32f
Part 1: Fix missing include in js/public. r=sfink

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/00441393b32f

Comment 9

[Takanori MATSUURA]

Only part 1 has been pushed.
leave-open?

Comment 10

[Tooru Fujisawa [:arai]]

There's ongoing effort to enforce IWYU. that covers what the abandoned patch was going to cover.